fix(argo-rollouts): Add traefik.io api group #2703
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This requires argo rollouts 1.7.0 as well, which did not release yet |
yu-croco
added
the
awaiting-upstream
yu-croco
reviewed
May 20, 2024
charts/argo-rollouts/Chart.yaml
Outdated
Comment on lines
21
to
22
| - kind: added | ||
| description: Added pod labels for the controller and the dashboard components |
There was a problem hiding this comment.
I have updated the chart changelog with all the changes that come with this pull request according to changelog.
Please remove old one.
I have bumped the chart version according to versioning
Also please bump version.
|
Hi @Kaswob , thank you for the PR. |
Kaswob
force-pushed
the
argo-rollouts-fix-traefik
branch
from
32bd2c0
to
ec70d41
Compare
|
@yu-croco bumped version and removed old changelog entry. I've also updated AppVersion to 1.7.0 so it will be ready for upstream release. Thanks for the info @DrFaust92 |
BlowaXD
reviewed
May 22, 2024
| @@ -248,6 +248,7 @@ rules: | |||
| # Traefik access needed when using the Traefik provider | |||
| - apiGroups: | |||
| - traefik.containo.us | |||
| - treafik.io | |||
There was a problem hiding this comment.
Yea, thanks for noticing ;) Fixed
Add traefik.io (which is the only supported apiGroup for traefik >3.0) to clusterrole and role of argo-rollouts chart Signed-off-by: Kamil Swoboda <[email protected]>
Kaswob
force-pushed
the
argo-rollouts-fix-traefik
branch
from
ec70d41
to
9c506b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add traefik.io (which is the only supported apiGroup for traefik >3.0) to clusterrole and role of argo-rollouts chart
Checklist: