fix(argo-cd): Fix static value secret name for argocd-server ingress tls secretName

[btwseeu78]

Checklist:

• I have bumped the chart version according to versioning
• I have updated the documentation according to documentation
• I have updated the chart changelog with all the changes that come with this pull request according to changelog.
• Any new values are backwards compatible and/or have sensible default.
• I have signed off all my commits as required by DCO.
• My build is green (troubleshooting builds).

[pdrastil]

Hi @btwseeu78 thanks for the PR. Hardcoding TLS secret name was intentional for TLS termination in Argo CD server. Also all certificates in chart are using this name to support this scenario. Can I ask why do you need different name?

See here: https://argo-cd.readthedocs.io/en/stable/operator-manual/tls/#tls-certificates-used-by-argocd-server

[btwseeu78]

Ok so let me explain the use case first, we use external secrets operator to pull certificates for diff clusters, then kubed is used to sync across namespaces. All our certificates are shared with multiple namespaces and a specific format to easily differentiate between what certificates for what hosts.Argocd tls means we need to just create another object to store the secrets,though we already have that with a diff name.
Also now we are doing it with extra-tls which does not feel right though it solves the issue.

Also what's the harm having it parameterised with a default values.
Also it's personal but I'm not ok to put ca data in values file and create the secret.

[zmx]

We have the same use case as btwseeu78

[mkilchhofer]

Somehow related:

• fix(argo-cd): remove secretName for server and applicationSet Certificates #2741

[mkilchhofer]

@pdrastil In my opinion it totally makes sense to have this configurable. Depending on the method used on the Ingress (e.g. SSL passthrough or not), operator docs uses different names for the secret:
https://argo-cd.readthedocs.io/en/stable/operator-manual/ingress/

So it is possible to use one TLS config for Argo CD's namespace-internal or in-cluster communication and use another TLS config on the Ingress.