feat(argo-cd): add support for dual stack clusters

[M0NsTeRRR]

Add support for dual stack clusters

Checklist:

• I have bumped the chart version according to versioning
• I have updated the documentation according to documentation
• I have updated the chart changelog with all the changes that come with this pull request according to changelog.
• Any new values are backwards compatible and/or have sensible default.
• I have signed off all my commits as required by DCO.
• My build is green (troubleshooting builds).

[yu-croco]

@M0NsTeRRR

I have updated the chart changelog with all the changes that come with this pull request according to changelog.

Please update (remove old one and add new one) changelog in Chart.yaml.

[M0NsTeRRR]

Done

[DrFaust92]

maybe worth to put this in helpers and allow this this to be a common setting on chart with override per service? im assuming whoever wants dual stack probably wants it globally

[mkilchhofer]

maybe worth to put this in helpers and allow this this to be a common setting on chart with override per service? im assuming whoever wants dual stack probably wants it globally

Maybe the simplest solution would be to move the per-service config inside the global section? Or may there be users only enabling this feature on some components?

refactoring ideas are in progress.

[M0NsTeRRR]

I always let the user choose regarding their setup. In other charts' PRs, they have asked me for per-service or global options as you mentionned, so it depends on your preference.
In my case, both setups are fine, so I have no preference for either.

I'll let you decide which one you choose, and I will update the PR to reflect this :)

[M0NsTeRRR]

Hello,
Have you decided on your preferred method for implementing this ?
Regards,

[mkilchhofer]

Hello, Have you decided on your preferred method for implementing this ? Regards,

I have no strict opinion but I'd go for a global option only. I cannot imagine a use case where you want to have different dualstack configs on component level within Argo CD. ;)

Just for simplicity of the code. If someone needs it in the future, we can extend the code at this point.

[M0NsTeRRR]

Hello, Have you decided on your preferred method for implementing this ? Regards,

I have no strict opinion but I'd go for a global option only. I cannot imagine a use case where you want to have different dualstack configs on component level within Argo CD. ;)

Just for simplicity of the code. If someone needs it in the future, we can extend the code at this point.

No problem, thanks for your answer. I will update the PR to reflect this :)

[mkilchhofer]

Thank you for implementing the requested changes 🙏

[M0NsTeRRR]

Your welcome, thanks for your review :)