-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(argo-cd): add support for passing redis - sentinel credentials #2492
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: ShlomiTubul <[email protected]>
Please handle this. |
Signed-off-by: ShlomiTubul <[email protected]>
Signed-off-by: shlomi tubul <[email protected]>
Signed-off-by: shlomi tubul <[email protected]>
Signed-off-by: shlomi tubul <[email protected]>
Signed-off-by: shlomi tubul <[email protected]>
Signed-off-by: shlomi tubul <[email protected]>
@shlomitubul PR looks good, we are just waiting on upstream to cherry pick this into release branch |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Any updates on when this might be merged for release? I'm working on a deployment where I'd like to use Sentinel but it looks like this is a blocker to that. |
Hi @corradomatt . |
Signed-off-by: shlomi tubul <[email protected]>
Signed-off-by: shlomi tubul <[email protected]>
yu-croco upstream change was release in 2.11.0, can we push this as well? |
Hi @DrFaust92 , thank you for reminding! Hi @shlomitubul , can you please resume this PR? |
Signed-off-by: shlomi tubul <[email protected]>
Signed-off-by: shlomi tubul <[email protected]>
Signed-off-by: shlomi tubul <[email protected]>
This PR enables authentication for external Redis with Sentinel by introducing REDIS_SENTINEL_USERNAME and REDIS_SENTINEL_PASSWORD as optional environment variables. These credentials can now be passed via secrets to the controller, repo-server, and server templates, mirroring the approach used for standard external Redis connections.
NOTE:
The actual support for username/password for Sentinel in argo code added in this PR:
argoproj/argo-cd#17168
Checklist: