Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(argo-cd): add support for passing redis - sentinel credentials #2492

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

shlomitubul
Copy link

@shlomitubul shlomitubul commented Feb 10, 2024

This PR enables authentication for external Redis with Sentinel by introducing REDIS_SENTINEL_USERNAME and REDIS_SENTINEL_PASSWORD as optional environment variables. These credentials can now be passed via secrets to the controller, repo-server, and server templates, mirroring the approach used for standard external Redis connections.

NOTE:
The actual support for username/password for Sentinel in argo code added in this PR:
argoproj/argo-cd#17168

Checklist:

  • I have bumped the chart version according to versioning
  • I have updated the documentation according to documentation
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.
  • My build is green (troubleshooting builds).

@shlomitubul shlomitubul changed the title feat: add support for passing redis - sentinel credentials feat (argo-cd): add support for passing redis - sentinel credentials Feb 10, 2024
@shlomitubul shlomitubul changed the title feat (argo-cd): add support for passing redis - sentinel credentials feat(argo-cd): add support for passing redis - sentinel credentials Feb 10, 2024
@pdrastil pdrastil added the awaiting-upstream Is waiting for a change upstream to be completed before it can be merged. label Feb 10, 2024
@yu-croco
Copy link
Collaborator

I have updated the chart changelog with all the changes that come with this pull request according to changelog.

Please handle this.

@shlomitubul
Copy link
Author

shlomitubul commented Feb 13, 2024

@yu-croco @pdrastil is there anything else that needs to be changed/fixed?

@pdrastil
Copy link
Member

pdrastil commented Mar 1, 2024

@shlomitubul PR looks good, we are just waiting on upstream to cherry pick this into release branch

Copy link

github-actions bot commented May 1, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@corradomatt
Copy link

Any updates on when this might be merged for release? I'm working on a deployment where I'd like to use Sentinel but it looks like this is a blocker to that.

@yu-croco
Copy link
Collaborator

yu-croco commented May 4, 2024

Hi @corradomatt .
As discussed #2492 (comment) , we are waiting for upstream that argoproj/argo-cd#17168 is released as specific version. 🙋
We will merge this PR as soon as upstream is handled.

@DrFaust92
Copy link
Contributor

yu-croco upstream change was release in 2.11.0, can we push this as well?

@yu-croco
Copy link
Collaborator

yu-croco commented Jun 6, 2024

Hi @DrFaust92 , thank you for reminding!
Yes, let's move on 🚀

Hi @shlomitubul , can you please resume this PR?

@yu-croco yu-croco removed awaiting-upstream Is waiting for a change upstream to be completed before it can be merged. on-hold labels Jun 6, 2024
Signed-off-by: shlomi tubul <[email protected]>
Signed-off-by: shlomi tubul <[email protected]>
Signed-off-by: shlomi tubul <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants