Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update dexIDP docker image to from v2.38.0 to v2.39.1 #18101

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

p0lipo
Copy link

@p0lipo p0lipo commented May 7, 2024

Summary

A new version of dexIDP got released last month and there some security issues fixed with that release.
https://github.com/dexidp/dex/releases/tag/v2.39.1

Currently, argo-cd appears to be running on 2.38.0

Motivation

There are a lot of dependency version updates in 2.39.0, some bug fixes and enchancements. 2.39.1 adds some additional bug fixes. Additionally there are some fixed security issues with the image.

Proposal

I think we should replace all occurrences of dex:v2.38.0 with dex:v2.39.1 and press thumbs that argo-cd is still working.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@p0lipo p0lipo requested a review from a team as a code owner May 7, 2024 08:28
@p0lipo
Copy link
Author

p0lipo commented May 7, 2024

linked issue: #18086

Copy link
Member

@gdsoumya gdsoumya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the ci-build.yaml workflow also uses dex for running tests which needs to be updated

Signed-off-by: Michael Crenshaw <[email protected]>
@p0lipo p0lipo requested a review from a team as a code owner May 8, 2024 15:32
@crenshaw-dev
Copy link
Collaborator

@p0lipo could you fix the DCO check?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants