Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for defining a custom list of ssh key exchange algorithms. #18007

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Gottox
Copy link

@Gottox Gottox commented Apr 27, 2024

Based on a quickfix from @zamedic, I implemented a feature that allows to define custom SSH key exchange algorithms in ArgoCD.

Allows to workaround issue #17634

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

This PR adds a feature to define custom ssh key exchange algorithms. This is needed to fix #17634.

This is a first proposal and hasn't been tested in depth yet.

@Gottox Gottox requested review from a team as code owners April 27, 2024 20:20
@Gottox Gottox changed the title add support for defining a custom list of ssh key exchange algorithms. feat: add support for defining a custom list of ssh key exchange algorithms. Apr 27, 2024
@Gottox Gottox force-pushed the add/ssh-kex-algorithms branch 3 times, most recently from 17a504e to 2ff5ab8 Compare April 27, 2024 20:34
@todaywasawesome
Copy link
Contributor

@jannfis Would you mind taking a look? Anything that touches encryption needs lots of 👀

@rouke-broersma
Copy link
Contributor

@jannfis Would you mind taking a look? Anything that touches encryption needs lots of 👀

@todaywasawesome @jannfis please read the complete linked issue, there is a lot of troubleshooting in there. While this change is useful I don't believe it addresses the immediate blocker people are experiencing.

@jannfis
Copy link
Member

jannfis commented Apr 30, 2024

Just as a heads-up, there is #18028 as the candidate to fix #17634

I will take a look at this PR later in the day :)

@Gottox
Copy link
Author

Gottox commented Apr 30, 2024

I leave that open, as it may be useful anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ArgoCD Repo Server stops pulling git repositories due to Azure Devops Repos current sunset SSH-RSA strategy
4 participants