Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change: deleted unused API v0 code #4852

Merged
merged 5 commits into from
May 23, 2024
Merged

Conversation

jfcalvo
Copy link
Member

@jfcalvo jfcalvo commented May 17, 2024

Description

This PR deletes old code associated to API v0 including handlers, schemas, tests and some related code. Some small changes were necessary on API v1 to support these deletions.

I also used vulture to find some dead code.

There is still some code that could be deleted. I was not 100% sure but is very likely that we can still delete some code that is unused. We can take a look to it @frascuchon

Closes #4839

Type of change

(Please delete options that are not relevant. Remember to title the PR according to the type of change)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (change restructuring the codebase without changing functionality)
  • Improvement (change adding some improvement to an existing functionality)
  • Documentation update

How Has This Been Tested

(Please describe the tests that you ran to verify your changes. And ideally, reference tests)

  • Deleted old tests and added small changes on the new ones.

Checklist

  • I added relevant documentation
  • follows the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I filled out the contributor form (see text above)
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@jfcalvo jfcalvo requested a review from frascuchon May 17, 2024 15:25
@jfcalvo I identified more unnecessary code.

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@jfcalvo jfcalvo merged commit 1df5a02 into feat/v2.0.0 May 23, 2024
8 checks passed
@jfcalvo jfcalvo deleted the change/delete-unused-code branch May 23, 2024 09:03
@jfcalvo jfcalvo linked an issue May 23, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK] Delete all migrated endpoints from API v0
2 participants