Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop the driver from killing everything on FUNC_SAVE_BEFORE_RESTART -… #21461

Closed
wants to merge 1 commit into from

Conversation

btsimonh
Copy link
Contributor

… since this is called in many other circumstances than an actual restart.

Description:

When applying other settings in various scenarios, settingssaveAll() is called, triggering FUNC_SAVE_BEFORE_RESTART.
The code responded to this by closing the webcam thread and cleaning up sockets, etc., expecting to go through a restart.

This commit disables this feature.

Tested on esp32s3 with cam and bluetooth enabled.

Checklist:

  • The pull request is done against the latest development branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • The code change is tested and works with Tasmota core ESP8266 V.2.7.6
  • The code change is tested and works with Tasmota core ESP32 V.3.0.0
  • I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

… since this is called in many other circumstances than an actual restart.
@btsimonh
Copy link
Contributor Author

Please hold this one.... Just realised WHY it's important to kill everything for a restart....
The Cam itself needs to be disabled, else in a restart scenario, it may not come back cleanly.
Hence implementing this change may mean you need to stop & start the cam after a restart.

Maybe better to think on #21460 before we jump.

@btsimonh
Copy link
Contributor Author

closing awaiting a new function for ending stuff at shutdown/restart...

@btsimonh btsimonh closed this May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant