Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add options for INA3221 driver #21310

Merged
merged 4 commits into from May 6, 2024

Conversation

fb-pilot
Copy link
Contributor

@fb-pilot fb-pilot commented May 1, 2024

Description:

A fresh try ... more defines for sensor100 INA3221 driver and extend documentatio
**Related issue (if applicable):#21262 + #1382

Checklist:

  • The pull request is done against the latest development branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • The code change is tested and works with Tasmota core ESP8266 V.2.7.6
  • The code change is tested and works with Tasmota core ESP32 V.3.0.0
  • I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

@Jason2866
Copy link
Collaborator

Jason2866 commented May 5, 2024

@fb-pilot Current driver INA3221 fails to compile. Errors occur when linking.
Please have a look and provide a PR to fix. Thx!
The bug is introduced with changes last week.

@fb-pilot
Copy link
Contributor Author

fb-pilot commented May 5, 2024

solved - thanks for testing.

@Jason2866
Copy link
Collaborator

@fb-pilot wrong folder for the driver ;-)

@fb-pilot
Copy link
Contributor Author

fb-pilot commented May 6, 2024

uups - that was too late yesterday night :-((

@Jason2866 Jason2866 merged commit 0d6baa0 into arendst:development May 6, 2024
59 checks passed
hawa-lc4 pushed a commit to hawa-lc4/Tasmota-dev that referenced this pull request May 7, 2024
* Add files via upload

* Add files via upload

* Add files via upload

* Delete tasmota/xsns_100_ina3221.ino

---------

Co-authored-by: Jason2866 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants