Update ble-cheat-sheet.md #1810
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed the RGB description and example code to reflect the fact that they are active-LOW and not active-HIGH.
jhansson-ard
requested review from
BenjaminDannegard,
karlsoderby,
jacobhylen and
Hannes7eicher
jhansson-ard
added
fix/update
jacobhylen
requested changes
Mar 12, 2024
There was a problem hiding this comment.
Hey @dkadish ☀️
Thanks for bringing this to our attention and for taking the time to fix it.
I see that we've made this error in the corresponding cheat sheets for the 3 other Nano 33 BLE boards as well (Nano 33 BLE, Nano 33 BLE Rev2, Nano 33 BLE Sense Rev2).
Can I ask you to apply these changes to those too? Then I'll go ahead and merge. :)
Thanks!
| @@ -354,22 +354,24 @@ If you want to learn more on how to use the Microphone, please check out the tut | |||
|
|
|||
| ## RGB | |||
|
|
|||
| To turn ON the pixels, write a `HIGH` state to the LED: | |||
| The Nano 33 BLE Sense's RGB LEDs are active-LOW, so they are switched in the opposite way to the LED_BUILTIN. | |||
There was a problem hiding this comment.
Suggested change
| The Nano 33 BLE Sense's RGB LEDs are active-LOW, so they are switched in the opposite way to the LED_BUILTIN. | |
| The Nano 33 BLE Sense's RGB LED is active-LOW, so it is active when the pins are set to `LOW`. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the RGB description and example code to reflect the fact that they are active-LOW and not active-HIGH.
What This PR Changes
Contribution Guidelines