Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gRPC: Added CheckForArduinoCLIUpdates RPC call #2573

Merged
merged 2 commits into from
Mar 26, 2024

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Mar 26, 2024

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

Adds a gRPC call CheckForArduinoCLIUpdates.

What is the current behavior?

No changes.

What is the new behavior?

Does this PR introduce a breaking change, and is titled accordingly?

No

Other information

This will be part of a bigger refactoring #2565

@cmaglie cmaglie self-assigned this Mar 26, 2024
@cmaglie cmaglie added this to the Arduino CLI v1.0.0 milestone Mar 26, 2024
@cmaglie cmaglie added type: enhancement Proposed improvement topic: gRPC Related to the gRPC interface labels Mar 26, 2024
Copy link
Contributor

@alessio-perugini alessio-perugini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that 🆒

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 24.27184% with 78 lines in your changes are missing coverage. Please review.

Project coverage is 69.47%. Comparing base (af85d57) to head (a54ed9e).

Files Patch % Lines
commands/updatecheck/check_for_updates.go 8.47% 54 Missing ⚠️
internal/cli/cli.go 62.50% 11 Missing and 1 partial ⚠️
internal/cli/version/version.go 0.00% 9 Missing ⚠️
commands/daemon/daemon.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2573      +/-   ##
==========================================
- Coverage   69.54%   69.47%   -0.08%     
==========================================
  Files         206      207       +1     
  Lines       20264    20283      +19     
==========================================
- Hits        14093    14092       -1     
- Misses       5054     5077      +23     
+ Partials     1117     1114       -3     
Flag Coverage Δ
unit 69.47% <24.27%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmaglie cmaglie merged commit 2d66dfa into arduino:master Mar 26, 2024
102 checks passed
@cmaglie cmaglie deleted the version_check_as_grpc branch March 26, 2024 15:43
@per1234 per1234 added the topic: code Related to content of the project itself label Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself topic: gRPC Related to the gRPC interface type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants