Introduce new "v" version format #2374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umbynos
added
type: enhancement
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2374 +/- ##
==========================================
- Coverage 62.82% 62.77% -0.06%
==========================================
Files 204 205 +1
Lines 19311 19283 -28
==========================================
- Hits 12132 12104 -28
Misses 6119 6119
Partials 1060 1060
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
alessio-perugini
requested changes
Oct 18, 2023
There was a problem hiding this comment.
All the workflow requires the regex starting with the v prefix. This is good if we're 💯 sure that we don't need to release any patch version for the old releases tagged without such a prefix.
IMO I don't think we need to release any patch version for the old release, therefore we can make v prefix mandatory also in the install.sh
alessio-perugini
approved these changes
Oct 18, 2023
cmaglie
reviewed
Oct 18, 2023
we'll keep 0.35.x release branch name. We'll use "v" only for the tag, this way the documentation branches will work just like before, we are using "v" only for the github tag this way we are semver compliant
alessio-perugini
approved these changes
Oct 19, 2023
dankeboy36
added a commit
to dankeboy36/ardunno-cli-gen
that referenced
this pull request
Oct 22, 2023
From Arduino CLI `>=0.35.0-rc.1`, the `v` prefix is expected in the GitHub release name. Ref: arduino/arduino-cli#2374 Signed-off-by: dankeboy36 <[email protected]>
dankeboy36
added a commit
to dankeboy36/ardunno-cli-gen
that referenced
this pull request
Oct 22, 2023
From Arduino CLI `>=0.35.0-rc.1`, the `v` prefix is expected in the GitHub release name. The asset filenames do not contain the prefix. Ref: arduino/arduino-cli#2374 Signed-off-by: dankeboy36 <[email protected]>
dankeboy36
added a commit
to dankeboy36/ardunno-cli-gen
that referenced
this pull request
Oct 22, 2023
From Arduino CLI `>=0.35.0-rc.1`, the `v` prefix is expected in the GitHub release name. The asset filenames do not contain the prefix. Ref: arduino/arduino-cli#2374 Signed-off-by: dankeboy36 <[email protected]>
kittaakos
pushed a commit
to arduino/arduino-ide
that referenced
this pull request
Oct 26, 2023
Ref: arduino/arduino-cli#2374 Signed-off-by: Akos Kitta <[email protected]>
kittaakos
pushed a commit
to arduino/arduino-ide
that referenced
this pull request
Nov 13, 2023
Ref: arduino/arduino-cli#2374 Signed-off-by: Akos Kitta <[email protected]>
kittaakos
pushed a commit
to arduino/arduino-ide
that referenced
this pull request
Nov 13, 2023
Ref: arduino/arduino-cli#2374 Signed-off-by: Akos Kitta <[email protected]>
kittaakos
pushed a commit
to arduino/arduino-ide
that referenced
this pull request
Nov 13, 2023
Ref: arduino/arduino-cli#2374 Signed-off-by: Akos Kitta <[email protected]>
dankeboy36
added a commit
to dankeboy36/install-from-gh-to-vscode
that referenced
this pull request
Dec 6, 2023
Ref: arduino/arduino-cli#2374 Signed-off-by: dankeboy36 <[email protected]>
dankeboy36
added a commit
to dankeboy36/install-from-gh-to-vscode
that referenced
this pull request
Dec 6, 2023
Ref: arduino/arduino-cli#2374 Signed-off-by: dankeboy36 <[email protected]>
dankeboy36
added a commit
to dankeboy36/install-from-gh-to-vscode
that referenced
this pull request
Dec 6, 2023
Ref: arduino/arduino-cli#2374 Signed-off-by: dankeboy36 <[email protected]>
kittaakos
pushed a commit
to arduino/arduino-ide
that referenced
this pull request
Dec 13, 2023
Ref: arduino/arduino-cli#2374 Signed-off-by: Akos Kitta <[email protected]>
kittaakos
pushed a commit
to arduino/arduino-ide
that referenced
this pull request
Dec 13, 2023
Ref: arduino/arduino-cli#2374 Signed-off-by: Akos Kitta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
Infrastructure change
What is the current behavior?
Fix #2341
What is the new behavior?
We release Arduino CLI with "v" version format
We still use
0.35.xformat for the doc branch and internally in the CLI the format is semver-compliant.Test run after pushing
0.35.xbranch: https://github.com/umbynos/arduino-cli/actions?query=branch%3A0.35.xTest run of
release-go-taskafter pushingv.0.35.0tag https://github.com/umbynos/arduino-cli/actions/runs/6576137988Does this PR introduce a breaking change, and is titled accordingly?
Technically no
Other information