WifiS3 Wificlient issues #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreagilardoni
force-pushed
the
wificlient-issues
branch
from
65b62d7
to
1ade2a0
Compare
per1234
added
type: imperfection
facchinm
approved these changes
May 8, 2024
|
in the title and in commit description it should be mentioned that it is for the WiFiS3 library. the platform has two WiFi libraries. a commit description "adding rx_buffer clear on stop call" is very unclear in the scope of the repository |
Like in parent class
When a client looses connection the client needs to be stopped before calling connect again
facchinm
force-pushed
the
wificlient-issues
branch
from
1ade2a0
to
c9a7485
Compare
pennam
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix the issue for which a client class is not able to connect again after a connection loss. This PR is applied to WifiS3 library.
Furthermore this PR adds: