Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return result from ArduinoLEDMatrix::begin() compatible with ArduinoGraphics. #225

Closed
wants to merge 1 commit into from

Conversation

PhilLogan
Copy link

Current implementation returns no value, resulting in annoying compiler warning - change returns value based on ArduinoGraphics docs (https://www.arduino.cc/reference/en/libraries/arduinographics/begin/).

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@per1234 per1234 added type: imperfection Perceived defect in any part of project topic: code Related to content of the project itself labels Dec 26, 2023
Copy link
Contributor

@aentinger aentinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍 Missing return statements could cause a whole host of problems down the line. Thank you 🙇

@aentinger
Copy link
Contributor

And I'm seeing that in order to merge this, I need you to sign the Contributor License Agreement. Could you please do that?

@pennam
Copy link
Contributor

pennam commented Feb 14, 2024

@PhilLogan could you please sign the CLA?

@per1234 per1234 added the status: waiting for information More information must be provided before work can proceed label Feb 14, 2024
@facchinm facchinm closed this May 24, 2024
@per1234 per1234 added conclusion: duplicate Has already been submitted and removed status: waiting for information More information must be provided before work can proceed labels May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: duplicate Has already been submitted topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants