Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WiFiC3: replace old build script #187

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

facchinm
Copy link
Member

@iabdalkader could you check if the produced binary is suitable for production?

libraries/WiFi/extra/README.md Outdated Show resolved Hide resolved
libraries/WiFi/extra/README.md Outdated Show resolved Hide resolved
libraries/WiFi/extra/README.md Outdated Show resolved Hide resolved
@per1234 per1234 added the topic: infrastructure Related to project infrastructure label Nov 15, 2023
@iabdalkader
Copy link
Contributor

@iabdalkader could you check if the produced binary is suitable for production?

Sure, I can get around to testing this week or the next.

@per1234 per1234 dismissed their stale review November 15, 2023 23:31

Suggested changes have been made. Thanks!

@arduino arduino deleted a comment from github-actions bot Dec 5, 2023
@iabdalkader
Copy link
Contributor

iabdalkader commented Dec 6, 2023

I see you removed flasher.sh I think we should keep it, or at least add the command to README.md (if it's not already documented somewhere else that I missed). Anyway, I tested this PR, with both Arduino and MicroPython, and the firmware produced by this build does Not work anymore, assuming this is the right command to flash the firmware:

esptool.py --chip esp32c3 -p /dev/ttyACM0 -b 230400 --before=default_reset --after=hard_reset write_flash --flash_mode dio --flash_freq 80m --flash_size 2MB 0x0 ESP32-C3.bin

Note it fails early when initializing the module, but the Arduino driver doesn't detect that it just gets stuck. I tested scan and NTP.

@pennam
Copy link
Contributor

pennam commented Feb 19, 2024

I've tested the PR after the last changes with Arduino and WiFi is working. I've flashed the firmware using esplflash

espflash write-bin 0x0 ESP32-C3.bin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: infrastructure Related to project infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants