Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$[HOME}/root/.config/mimeapps.list
folder doesn't look correct to mechmod +x
is wrong, this file is not supposed be executableFinally, why you create an empty mimeapps.list? how is this supposed to fix #7846?
From what I read in #7846 there is
xdg-mime
that cannot create/root/.local/share/applications/mimeapps.list.new
becuase the parent directory is nonexistent.Are you able to reproduce the error reported in the issue #7846 ? If yes, have you tested this fix before submitting?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cmaglie
yes, I was able to reproduce the error reported, and yes and I did the test before I submitted my PR, whatever PR I have given for this organization during the GSOC period, have been tested and reproduced the same, so that my PR may be merged efficiently without any problems. I am still working on one of the features in Arduino-cli. Though it might look wrong to you, I have tried my best to tackle that issue I encounter with it and came up with this reasonable solution, which apparently solves the issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and after adding this patch to the code, this is what is written in that particular file,
mimeapps.list