Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfixes on tests and github actions runner for Windows #10196

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Bugfixes on tests and github actions runner for Windows #10196

wants to merge 15 commits into from

Commits on Jun 19, 2020

  1. Fix "illegal char" in build.xml 

    CI run on windows produce the following error:

D:\a\Arduino\Arduino\build\build.xml:365: java.nio.file.InvalidPathException: Illegal char <*> at index 42: D:\a\Arduino\Arduino\build\macosx\arduino-*.dmg
    @cmaglie
    cmaglie committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    122ad00 View commit details
    Browse the repository at this point in the history

  2. Rename unit-test gh action

    @cmaglie
    cmaglie committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    223a6a1 View commit details
    Browse the repository at this point in the history

  3. Run tests without creating 'dist' 

    Previously the <input...> tag was removed with sed to avoid hitting enter
on the version number prompt. We can just skip the dist step altogether
instead.
    @cmaglie
    cmaglie committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    4a5e304 View commit details
    Browse the repository at this point in the history

  4. Added windows testing

    @cmaglie
    cmaglie committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    6cb1625 View commit details
    Browse the repository at this point in the history

  5. Always publish results

    @cmaglie
    cmaglie committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    941363c View commit details
    Browse the repository at this point in the history

  6. prevent CRLF poisoning of data file for unit tests

    @cmaglie
    cmaglie committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    7852fc1 View commit details
    Browse the repository at this point in the history

  7. Fixed JSONDownloader tests on Windows

    @cmaglie
    cmaglie committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    720b7a9 View commit details
    Browse the repository at this point in the history

  8. Fixed SerialTest on Windows 

    It looks like that on Windows string builders use a default encoding that
is different from UTF-8.
    @cmaglie
    cmaglie committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    24bf3eb View commit details
    Browse the repository at this point in the history

  9. Fixed CommandLineTests for Windows

    @cmaglie
    cmaglie committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    a6ef343 View commit details
    Browse the repository at this point in the history

  10. Put require .dll together with work/java/bin/java 

    This allows the library loader to find them even if arduino_debug.exe or
arduino.exe is started from a different directory for example from the
command prompt.
    @cmaglie
    cmaglie committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    ac3d1fe View commit details
    Browse the repository at this point in the history

  11. Replaced FEST with assertJ

    @cmaglie
    cmaglie committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    74a66e5 View commit details
    Browse the repository at this point in the history

  12. Print details for failed tests

    @cmaglie
    cmaglie committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    5e9d0cc View commit details
    Browse the repository at this point in the history

  13. Explicitly pass output stream in runArduino(..) test function 

    Previously while testing on Windows, if the process produces a lot of
output that is not consumed, the pr.Wait() call will never end
because the OS doesn't have enough buffering.
    @cmaglie
    cmaglie committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    ef5d316 View commit details
    Browse the repository at this point in the history

  14. Fixed EditorConsoleTest on Windows 

    For some reason the consolePane.getText() method returns the document
text with single CR translated into OS native CR+LF. This will influence
test outcome since we check various combinations of CR and LF.
    @cmaglie
    cmaglie committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    ea25c35 View commit details
    Browse the repository at this point in the history

  15. test: gather all output before going on with tests 

    Wait for consumer thread to collect all output before returning from
command line run. This patch avoid a race condition (the test output
is checked before all the output is actually collected).
    @cmaglie
    cmaglie committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    1621776 View commit details
    Browse the repository at this point in the history