Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 🎨 Adding support for direct background colors. #33

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

architeacher
Copy link
Owner

[minor]

Signed-off-by: Ahmed Kamal [email protected]

New changes are awesome

What does this do

Added support for direct background colors.

Why is it a good idea

Extra features

How I did it

Using the background mode constant defined.

How to verify it

Through direct use of the feature, and unit tests.

Remarks

NA

Release note

NA

@codecov
Copy link

codecov bot commented Jul 23, 2022

Codecov Report

Merging #33 (b63d0b9) into main (3dfd330) will not change coverage.
The diff coverage is 100.00%.

❗ Current head b63d0b9 differs from pull request most recent head 654c44b. Consider uploading reports for the commit 654c44b to get more accurate results

@@            Coverage Diff            @@
##              main       #33   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         4    +1     
  Lines          238       291   +53     
=========================================
+ Hits           238       291   +53     
Impacted Files Coverage Δ
color.go 100.00% <ø> (ø)
colorable.go 100.00% <100.00%> (ø)
direct_color.go 100.00% <100.00%> (ø)
style.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@architeacher architeacher force-pushed the feature/adding-support-for-direct-background-colors branch from 85f22a6 to 74a162d Compare July 23, 2022 19:34
@architeacher architeacher force-pushed the feature/adding-support-for-direct-background-colors branch 12 times, most recently from cc49b42 to b63d0b9 Compare August 17, 2022 06:58
@architeacher architeacher force-pushed the feature/adding-support-for-direct-background-colors branch from b63d0b9 to 654c44b Compare August 17, 2022 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant