Fix race condition in dotnet first time use experience #1414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grospelliergilles
added
arcane
Si la cible 'dotnet_axl' existe, ajoute une dépendance à cette cible pour les projets utilisant le C# pour garantir qu'il n'y a qu'un seul projet exécuté à la fois. Cela est nécessaire pour le CI car lors de la première utilisation de `dotnet` il y a des créations de répertoire et cela pose problème si c'est exécuté par plusieurs instances à la fois.
grospelliergilles
force-pushed
the
dev/gg-fix-race-condition-in-dotnet-first-experience
branch
from
c95b246
to
a90c688
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1414 +/- ##
==========================================
- Coverage 69.04% 69.04% -0.01%
==========================================
Files 2064 2064
Lines 152214 152214
Branches 17469 17469
==========================================
- Hits 105102 105098 -4
- Misses 40813 40817 +4
Partials 6299 6299 ☔ View full report in Codecov by Sentry. |
grospelliergilles
deleted the
dev/gg-fix-race-condition-in-dotnet-first-experience
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If target
dotnet_axlexists, add a dependency to this target to projects using C# to ensure there is only one projectexecuted at once. This is necessary for the CI because during the first use of
dotnetthere are directory creations and this poses problem if it is executed by several instances at the same time.