Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): use google.golang.org/protobuf/types/known instead of github.com/golang/protobuf/ptypes #6681

Merged
merged 1 commit into from
May 15, 2024

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented May 14, 2024

Description

use google.golang.org/protobuf/types/known instead of github.com/golang/protobuf/ptypes
this also removes github.com/golang/protobuf from the list of direct dependencies to use the recommanded google.golang.org/protobuf

…thub.com/golang/protobuf/ptypes

Signed-off-by: Matthieu MOREL <[email protected]>
@mmorel-35 mmorel-35 requested a review from knqyf263 as a code owner May 14, 2024 09:55
@knqyf263
Copy link
Collaborator

use the recommanded google.golang.org/protobuf

Thanks for your contribution. Is there any document about this recommendation?

@mmorel-35
Copy link
Contributor Author

It is in the first lines of the readme in
https://github.com/golang/protobuf?tab=readme-ov-file#go-support-for-protocol-buffers

@knqyf263 knqyf263 added this pull request to the merge queue May 15, 2024
Merged via the queue into aquasecurity:main with commit 1ad47c2 May 15, 2024
14 checks passed
@mmorel-35 mmorel-35 deleted the protobuf branch May 15, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants