pkg: replace utils/strings/InSlice func with slices.Contains
#413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
In this commit, we replace `utils/strings/InSlice` function with the built-in `slices.Contains` function which is supported in go 1.18+ and it would work with the current project go version `1.19`. Signed-off-by: Mohamed Awnallah <[email protected]>
mohamedawnallah
force-pushed
the
replaceInSliceWithSlicesContains
branch
from
cd0720f
to
a7c398a
Compare
knqyf263
approved these changes
Jul 1, 2024
|
I think |
|
Ah sorry my bad. Your are right: |
|
opened #415 |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this commit, we replace
utils/strings/InSlicefunction with the built-inslices.Containsfunction which is supported in go 1.18+ and it would work with the current project go version1.19as appears in thego.modfile.Closes #245
How has this been tested?
I've run the test cases using
make testand all of them passed.