Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed icons size and update copyright year #134

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

amanr-dev
Copy link

What does this PR do?

The size of the icons was so small. So in this PR, the icon's size is fixed.

Copy link

changeset-bot bot commented Dec 21, 2023

⚠️ No Changeset found

Latest commit: 6cc21d0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Dec 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
pink-design ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 12, 2024 7:43am
ui-kitchensink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 12, 2024 7:43am

@amanr-dev
Copy link
Author

amanr-dev commented Dec 21, 2023

For the example

Before :
Before

After :
After

Copy link
Contributor

Uh oh! @amanr-dev, the image you shared is missing helpful alt text. Check #134 (comment).

Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.

Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.

@amanr-dev
Copy link
Author

Hi @TorstenDittmann , please review the PR.

packages/icons/scripts.js Outdated Show resolved Hide resolved
@amanr-dev
Copy link
Author

Hi @TorstenDittmann, now you can review the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants