fix: show generic support button by default instead of premium support button #984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
2 tasks
stnguyen90
reviewed
Mar 29, 2024
| @@ -44,7 +44,18 @@ | |||
| </p> | |||
| {/if} | |||
| </div> | |||
| {#if $organization?.billingPlan === BillingPlan.STARTER} | |||
| {#if $organization?.billingPlan === BillingPlan.PRO || $organization?.billingPlan === BillingPlan.SCALE} | |||
There was a problem hiding this comment.
So, this is shown now if no org exists:
But the "Get Premium support" button doesn't do anything.
There was a problem hiding this comment.
Also, what if I have a pro org, but I'm on the account page??
stnguyen90
requested changes
Mar 29, 2024
| @@ -44,7 +44,18 @@ | |||
| </p> | |||
| {/if} | |||
| </div> | |||
| {#if $organization?.billingPlan === BillingPlan.STARTER} | |||
| {#if $organization?.billingPlan === BillingPlan.PRO || $organization?.billingPlan === BillingPlan.SCALE} | |||
There was a problem hiding this comment.
Also, what if I have a pro org, but I'm on the account page??
stnguyen90
reviewed
Mar 29, 2024
src/lib/components/support.svelte
Outdated
| }}> | ||
| <span class="text">Contact our Support Team</span> | ||
| </Button> | ||
| {:else} |
There was a problem hiding this comment.
We should also handle the case where I click the "Get Premium support" when I'm on the account page and I do have an org. Right now, it shows the "Get premium support" button, but clicking does nothing (because $organization isn't set).
…button-default-state
…nt and onboarding pages)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #979