Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve container naming conventions #8083

Merged
merged 5 commits into from May 16, 2024
Merged

Improve container naming conventions #8083

merged 5 commits into from May 16, 2024

Conversation

PineappleIOnic
Copy link
Member

What does this PR do?

This PR fixes naming conventions in Appwrite and also adds a small guide in CONTRIBUTING.md explaining the naming conventions.

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

@PineappleIOnic PineappleIOnic requested review from eldadfux and abnegate and removed request for eldadfux May 15, 2024 05:52
abnegate
abnegate reviewed May 15, 2024
View reviewed changes
Copy link
Contributor

@abnegate abnegate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think realtime or assisstant should be using the task prefix

abnegate
abnegate reviewed May 15, 2024
View reviewed changes
Copy link
Contributor

@abnegate abnegate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should do this in app/views/install/compose.phtml as well

@christyjacob4 christyjacob4 merged commit 33587a2 into main May 16, 2024
23 checks passed
@christyjacob4 christyjacob4 deleted the fix-container-naming branch May 16, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abnegate abnegate abnegate approved these changes

@christyjacob4 christyjacob4 christyjacob4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@PineappleIOnic @abnegate @christyjacob4