Fix MFA email verification code font #8082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The font family was set to Inter without any fallback and since the Inter isn't available in emails, the font rendered the default font, Times New Roman. This commit adds a fallback font to the font-family ensuring an sans-serif font like Inter is used.
stnguyen90
added
the
product / auth
PineappleIOnic
approved these changes
May 7, 2024
TorstenDittmann
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The font family was set to Inter without any fallback and since the Inter isn't available in emails, the font rendered the default font, Times New Roman. This commit adds a fallback font to the font-family ensuring an sans-serif font like Inter is used.
Test Plan
Tested by triggering the email into Maildev and then forwarding it to Gmail:
Before:
After:
Related PRs and Issues
None
Checklist