Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
perf: Anvil widget name component rendering (#33672)
## Description - Fixes some of the performance issues in the widget name component for Anvil. Particularly, the following - All widget name components for all widgets used to be added to the DOM tree, even if they're not visible - All widget name components had the floating-ui listeners added to them at all times, leading to a sharp rise in the number of JS listeners and increasing RAM usage. - Widget name component positions used to recompute sporadically, leading to perceived jitter when users scrolled too quickly. The above issues have been fixed by the following changes - Widget name component gets added to the DOM only when `nameComponentState !== "none"` - Widget name component only has listeners added by floating-ui when the name component needs to be visible - Floating-ui is configured to recompute in all `requestAnimationFrame` cycles Fixes #33386 Fixes #33330 ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!CAUTION] > 🔴 🔴 🔴 Some tests have failed. > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9205700153> > Commit: db2487d > Cypress dashboard: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9205700153&attempt=1&selectiontype=test&testsstatus=failed&specsstatus=fail" target="_blank"> Click here!</a> > The following are new failures, please fix them before merging the PR: <ol> > <li>cypress/e2e/Regression/ClientSide/BugTests/GitBugs_Spec.ts </ol> > To know the list of identified flaky tests - <a href="https://internal.appsmith.com/app/cypress-dashboard/identified-flaky-tests-65890b3c81d7400d08fa9ee3?branch=master" target="_blank">Refer here</a> <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No
- Loading branch information