Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn error backend off by default #931

Merged
merged 2 commits into from
Jun 4, 2024
Merged

Conversation

jeffkreeftmeijer
Copy link
Member

The error backend is a relic of the past, which caught otherwise uncaught errors before we had proper instrumentation through library-specific instrumentation and :telemetry.

Also, the error backend produced confusing results, as the errors it reports are void of context, making them hard to understand at best.

This patch turns the error backend off by default if it's unconfigured, in preparation of removing the backend in a future version.

The error backend is a relic of the past, which caught otherwise
uncaught errors before we had proper instrumentation through
library-specific instrumentation and :telemetry.

Also, the error backend produced confusing results, as the errors it
reports are void of context, making them hard to understand at best.

This patch turns the error backend off by default if it's unconfigured,
in preparation of removing the backend in a future version.
@backlog-helper

This comment has been minimized.

@jeffkreeftmeijer jeffkreeftmeijer marked this pull request as ready for review April 17, 2024 11:24
@jeffkreeftmeijer
Copy link
Member Author

This is ready for review. Let's bite the bullet and flip the switch, as we don't see any valuable data coming in through the error handler.

@backlog-helper

This comment has been minimized.

5 similar comments
@backlog-helper

This comment has been minimized.

@backlog-helper

This comment has been minimized.

@backlog-helper

This comment has been minimized.

@backlog-helper

This comment has been minimized.

@backlog-helper

This comment has been minimized.

@tombruijn
Copy link
Member

Let's review if it is not really necessary. @jeffkreeftmeijer will take a look. It could be interesting to track process crashes rather than errors we didn't catch.

@backlog-helper

This comment has been minimized.

3 similar comments
@backlog-helper

This comment has been minimized.

@backlog-helper

This comment has been minimized.

@backlog-helper

This comment has been minimized.

@backlog-helper

This comment has been minimized.

5 similar comments
@backlog-helper

This comment has been minimized.

@backlog-helper

This comment has been minimized.

@backlog-helper

This comment has been minimized.

@backlog-helper

This comment has been minimized.

@backlog-helper

This comment has been minimized.

@backlog-helper

This comment has been minimized.

8 similar comments
@backlog-helper

This comment has been minimized.

@backlog-helper

This comment has been minimized.

@backlog-helper

This comment has been minimized.

@backlog-helper

This comment has been minimized.

@backlog-helper

This comment has been minimized.

@backlog-helper

This comment has been minimized.

@backlog-helper

This comment has been minimized.

@backlog-helper
Copy link


This is a message from the daily scheduled checks.

New issue guide | Backlog management | Rules | Feedback

@backlog-helper
Copy link

This Pull Request has received its first reminder more than 50 days ago. This is the final reminder. It will be no longer included in reminders going forward.

New issue guide | Backlog management | Rules | Feedback

@jeffkreeftmeijer jeffkreeftmeijer merged commit cb7c2e9 into main Jun 4, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants