[Compile Time Constant Extraction] Extract KeyPath Expressions #73718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
venkatesh5789
requested review from
artemcm and
jPaolantonio
and removed request for
xedin,
slavapestov and
hborla
artemcm
approved these changes
May 17, 2024
venkatesh5789
force-pushed
the
keypath-extraction
branch
3 times, most recently
from
bb646b8
to
bde30ef
Compare
artemcm
approved these changes
May 21, 2024
artemcm
approved these changes
May 21, 2024
|
@swift-ci test |
artemcm
reviewed
May 22, 2024
| // CHECK-NEXT: "typeName": "ExtractKeyPaths.KeyPaths", | ||
| // CHECK-NEXT: "mangledTypeName": "15ExtractKeyPaths0bC0V", | ||
| // CHECK-NEXT: "kind": "struct", | ||
| // CHECK-NEXT: "file": "SOURCE_DIR/test/ConstExtraction/ExtractKeyPaths.swift", |
There was a problem hiding this comment.
To have these tests work on windows, I believe instead of / you need to specify {{/|\\}}.
There was a problem hiding this comment.
Ok changed that and restarted the tests.
venkatesh5789
force-pushed
the
keypath-extraction
branch
from
bde30ef
to
4483fb9
Compare
|
@swift-ci test |
venkatesh5789
force-pushed
the
keypath-extraction
branch
from
4483fb9
to
6e797f5
Compare
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for extracting key path variables
Example: