Only add a name section if one doesn't already exist #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We may want to add more methods to sniff out various parts of the document. Stuffing them all inline is going to make the `sniff` method into a pretty big mess, so we'll split out the existing stuff into its own method. We can add more methods to do other kinds of content sniffing as needed.
Documents may already have NAME sections which already have name and tagline, so we should try that before looking at the H1 header. The sections may use the hyphenated form, which we can split up as name and tagline, or they may just have the name of the page. We can handle both.
Some documents may include a NAME section in the original text. We'll make sure to check before we add one of our own; if there's already one, we can skip adding a new one.
adminspotter
force-pushed
the
one-name-section-please
branch
from
1678e67
to
2397449
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ronn would add a second
## NAMEsection even If an input document already has one.A couple of interconnected changes here:
## NAMEheader, and dig inside it for metadata. This allows users to not have to provide the--namecommand-line flag.<h2>NAME</h2>, and if so, we won't add anything.I added unit tests for everything.
This should fix up #33