-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sync: hosted cloud #1734
Merged
Merged
sync: hosted cloud #1734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Human says As a human, what have you done for this pull request? Why? What? How? <!-- 如果这个Pull Request有对应的Issue,你可以复制Issue的相关信息。 --> <!-- # Why? > 对应哪个issue? > 为什么要这个pull request? > 背景故事或原因是怎样的? > 你理解的业务需求是怎样的? --> <!-- # What? > 这是一个什么Pull Request? > 描述一下是什么? > 对哪些人有好处? --> <!-- # How? > 大概描述下,如何具体实现的这个Pull Request? --> # AI says <!-- AI auto review added here --> <!-- This is an auto-generated comment: release notes by OSS CodeRabbit --> ### Summary by CodeRabbit - Refactor: Updated import statements for the `Workdoc` component in `workdoc_editor.tsx` and `activity_pane.tsx` to use the correct import paths. - Refactor: Removed unnecessary export statement for the `activity_pane` module in `index.ts`. - Refactor: Dynamically imported the `ActivityPaneNoSSR` component in `expand_record.tsx` and updated props passed to it. - Refactor: Updated import statement for the `AnimationItem` component in `form_container.tsx` and `user_menu.tsx` to use the correct import path. - Refactor: Dynamically imported the `lottie` library in `auto_save_lottie.tsx` and `manual_save_lottie.tsx`, removing the need for `useRef` hook and simplifying the code. - Refactor: Removed export statements for the `workdoc` and `collaboration_editor` modules in `index.ts`. These changes primarily involve refactoring import statements, dynamically importing components/libraries, and removing unnecessary export statements. They do not introduce new features or fix bugs visible to end-users. <!-- end of auto-generated comment: release notes by OSS CodeRabbit -->
close #10532 close #10525 <!-- This is an auto-generated comment: release notes by OSS CodeRabbit --> ### Summary by CodeRabbit - New Feature: Added support for converting Bilibili URLs in the `EmbedPage` component. Users can now paste Bilibili video URLs, and if the active configuration is set to 'embed_link_bilibili', the URL will be automatically converted to an embeddable format. - Bug Fix: Fixed an issue where the `openSetting` state in the `EmbedPage` component was not being updated correctly. Now, when a specific node exists in the `treeNodesMap`, the settings panel will be closed, providing a better user experience. - Test: Added tests for the new `convertBilibiliUrl` function to ensure proper conversion of Bilibili URLs. - Refactor: Extracted the logic for extracting the Bilibili video ID from a URL into a separate function for improved modularity and readability. <!-- end of auto-generated comment: release notes by OSS CodeRabbit -->
<!-- This is an auto-generated comment: release notes by OSS CodeRabbit --> ### Summary by CodeRabbit - Refactor: Moved the import statement for `useAppSelector` to the top and removed duplicated import statement in the `use_grid.tsx` file. - Refactor: Added a type assertion to the `useGrid` function in the `use_grid.tsx` file. These changes improve code organization and ensure type safety in the `use_grid.tsx` file. They do not introduce any new features or bug fixes visible to the end-user. <!-- end of auto-generated comment: release notes by OSS CodeRabbit -->
- fix: #10540 - fix: #10539 - fix: #10538 - fix: #10534 - fix: #10536
@coderabbitai: ignore Co-authored-by: Zoe <[email protected]>
# Human says As a human, what have you done for this pull request? Why? What? How? <!-- 如果这个Pull Request有对应的Issue,你可以复制Issue的相关信息。 --> <!-- # Why? > 对应哪个issue? > 为什么要这个pull request? > 背景故事或原因是怎样的? > 你理解的业务需求是怎样的? --> <!-- # What? > 这是一个什么Pull Request? > 描述一下是什么? > 对哪些人有好处? --> <!-- # How? > 大概描述下,如何具体实现的这个Pull Request? --> # AI says <!-- AI auto review added here --> Co-authored-by: xukecheng <[email protected]>
- fix: #10387 <!-- This is an auto-generated comment: release notes by OSS CodeRabbit --> ### Summary by CodeRabbit - Bug Fix: Fixed the visual layout issue in the `DisabledShareFile` component by increasing the height of an image from 150 to 195 pixels. - Refactor: Improved code organization and removed unnecessary elements in the `public_share_invite_link.tsx` file. Also added a check for `spaceFeatures.fileSharable` to conditionally render a component based on its value. <!-- end of auto-generated comment: release notes by OSS CodeRabbit -->
- fix: #10404 <!-- This is an auto-generated comment: release notes by OSS CodeRabbit --> ### Summary by CodeRabbit - Bug Fix: Fixed an issue with unarchiving a record link in the `linked_data_conformance_maintainer.ts` file. The code now correctly updates the `newLinkedCellValue` array by removing specified elements and adding new ones. - Refactor: Modified the `execute` function of the `archiveRecord` command in the `archive_record.ts` file. Removed the `ldcMaintainer.insert` function call and updated the destructuring assignment to improve code clarity and maintainability. These changes do not affect the external behavior of the code. <!-- end of auto-generated comment: release notes by OSS CodeRabbit -->
@coderabbitai: ignore fix: - #9807
- fix: #10567 <!-- This is an auto-generated comment: release notes by OSS CodeRabbit --> ### Summary by CodeRabbit - Refactor: Removed commented-out code block that extended the `CollaCommandManager` interface in `set_records.ts`. - Bug Fix: Added validation for archived record IDs in the `LinkField` class to ensure they are included when validating the `value` array in `link_field.ts`. - Refactor: Modified the assignment of the `filterCellValue` variable in `search_content.tsx` to always filter `cellValue` based on certain conditions. <!-- end of auto-generated comment: release notes by OSS CodeRabbit -->
@coderabbitai: ignore Co-authored-by: Zoe <[email protected]>
close #10564 close #10514 close #10241 <!-- This is an auto-generated comment: release notes by OSS CodeRabbit --> ### Summary by CodeRabbit - Refactor: Removed automatic formatting of staged files using Prettier in the `check_forbidden_folder` function. - New Feature: Added a new environment variable `EDITION` to the `getEnvVars` function for better configuration. - Refactor: Improved readability and simplified code in the `getConditionValue` function by accessing `envVars` directly instead of using console.log and string manipulation. - Chore: Updated import statement in the `mirror_route.tsx` file for better module resolution. - Logic: Modified the `Share` component to return early if `nodeId` starts with "mir", affecting the behavior of the component. - Refactor: Made several changes to the `SubAdmin` component, including import statement reordering, variable removal, and modifications to the `Typography` component. - Refactor: Made various improvements to the `ResourceService` class, such as constructor formatting, arrow function parameter parentheses, and forEach loop syntax. - Logic: Changed condition checks in two functions (`useGetPermission` and `useGetNodeDesc`) by replacing the prefix check from `'emp'` to `'cup'`. - Refactor: Modified regular expressions used for matching paths in the `use_page_params.ts` file, potentially impacting the behavior of the `getPageParams` function. <!-- end of auto-generated comment: release notes by OSS CodeRabbit -->
@coderabbitai: ignore Co-authored-by: Zoe <[email protected]>
@coderabbitai: ignore --------- Co-authored-by: Zoe <[email protected]>
- fix: #9380 <!-- This is an auto-generated comment: release notes by OSS CodeRabbit --> ### Summary by CodeRabbit - New Feature: Updated the `FilterCascader` component to handle cascader fields and linked fields more effectively. - Bug Fix: Fixed an issue in the `FilterValue` component where the `primaryField` prop was not being passed correctly to the `Cascader` component. - Refactor: Made changes to the `WidgetItem` component, including conditional rendering of different components based on certain conditions. Improved import organization and grouping. - Chore: Updated import statements in various components to include additional modules from `@apitable/core` and `'pc/store/react-redux'`. <!-- end of auto-generated comment: release notes by OSS CodeRabbit -->
# Human says 更新自定义页面节点相关的文案,补充多语言文案 # AI says <!-- AI auto review added here -->
…ge-release # Conflicts: # apitable/packages/core/src/config/stringkeys.interface.ts # apitable/packages/l10n/base/strings.en-US.json
# Human says As a human, what have you done for this pull request? Why? What? How? <!-- 如果这个Pull Request有对应的Issue,你可以复制Issue的相关信息。 --> <!-- # Why? > 对应哪个issue? > 为什么要这个pull request? > 背景故事或原因是怎样的? > 你理解的业务需求是怎样的? --> <!-- # What? > 这是一个什么Pull Request? > 描述一下是什么? > 对哪些人有好处? --> <!-- # How? > 大概描述下,如何具体实现的这个Pull Request? --> # AI says <!-- AI auto review added here --> <!-- This is an auto-generated comment: release notes by OSS CodeRabbit --> ### Summary by CodeRabbit - Refactor: Updated import statements in various files to use single quotes instead of double quotes and reordered imports alphabetically. - Refactor: Removed unused import statements and added missing semicolons in import statements. - Refactor: Rearranged the order of import statements in some files. - New Feature: Changed the import statement for the `IEmbedProps` interface, which may affect the external interface or behavior of the code. - Documentation: Improved code structure and organization in the `AlarmTipText` component. - Style: Made formatting and indentation changes in the `date_time_alarm.tsx` file. - Test: No test-related changes were identified. - Chore: No significant chore-related changes were identified. <!-- end of auto-generated comment: release notes by OSS CodeRabbit -->
# Conflicts: # apitable/CHANGELOG.md # apitable/backend-server/application/src/main/java/com/apitable/shared/util/IdUtil.java # apitable/backend-server/application/src/main/java/com/apitable/workspace/enums/IdRulePrefixEnum.java # apitable/backend-server/application/src/main/java/com/apitable/workspace/enums/NodeType.java # apitable/backend-server/application/src/main/java/com/apitable/workspace/service/impl/NodeServiceImpl.java # apitable/backend-server/application/src/test/java/com/apitable/workspace/service/impl/NodeServiceImplTest.java # apitable/packages/core/src/config/stringkeys.interface.ts # apitable/packages/core/src/config/timezones.ts # apitable/packages/core/src/utils/convert/other2timestamp.ts # apitable/packages/datasheet/src/pc/components/editors/date_time_editor/date_time_editor.tsx # apitable/packages/datasheet/src/pc/components/editors/link_editor/search_content.tsx # apitable/packages/datasheet/src/pc/components/embed_page/__test__/convert.test.ts # apitable/packages/datasheet/src/pc/components/embed_page/components/setting/setting_inner.tsx # apitable/packages/datasheet/src/pc/components/embed_page/embed_page.tsx # apitable/packages/datasheet/src/pc/components/embed_page/utils/convert-url.ts # apitable/packages/datasheet/src/pc/components/konva_grid/utils/cell_helper.ts # apitable/packages/datasheet/src/pc/components/preview_file/tool_bar/tool_bar.tsx # apitable/packages/datasheet/src/pc/components/preview_file/workdoc_image/style.module.less # apitable/packages/datasheet/src/pc/components/preview_file/workdoc_image/workdoc_image.tsx # apitable/packages/datasheet/src/pc/components/tab_bar/description_modal/description_modal.tsx # apitable/packages/datasheet/src/pc/hooks/use_page_params.ts # apitable/packages/datasheet/src/pc/styles/lib_mixins.less # apitable/packages/l10n/base/strings.en-US.json # apitable/packages/l10n/base/strings.zh-CN.json # apitable/pnpm-lock.yaml
# Human says As a human, what have you done for this pull request? Why? What? How? <!-- 如果这个Pull Request有对应的Issue,你可以复制Issue的相关信息。 --> <!-- # Why? > 对应哪个issue? > 为什么要这个pull request? > 背景故事或原因是怎样的? > 你理解的业务需求是怎样的? --> <!-- # What? > 这是一个什么Pull Request? > 描述一下是什么? > 对哪些人有好处? --> <!-- # How? > 大概描述下,如何具体实现的这个Pull Request? --> # AI says <!-- AI auto review added here --> <!-- This is an auto-generated comment: release notes by OSS CodeRabbit --> ### Summary by CodeRabbit - Bug Fix: Fixed various bugs in version `v1.8.0-beta.2` and `v1.8.0-beta.1`. - Sync with Hosted Cloud: Synchronized the `apitable` module with the hosted cloud, ensuring data consistency and compatibility. <!-- end of auto-generated comment: release notes by OSS CodeRabbit -->
@coderabbitai: ignore Co-authored-by: Zoe <[email protected]>
close #10522 <!-- This is an auto-generated comment: release notes by OSS CodeRabbit --> ### Summary by CodeRabbit - Style: Improved code readability and formatting in the `EditableText` component, `activity_item/style.module.less`, and `expand_record/style.module.less`. - Bug Fix: Updated the rendering logic in the `EmbedPage` component to also render the `NoPermission` component when both the `role` and `shareId` variables are falsy. - Documentation: No changes related to documentation were made in this pull request. <!-- end of auto-generated comment: release notes by OSS CodeRabbit -->
# Human says As a human, what have you done for this pull request? Why? What? How? <!-- 如果这个Pull Request有对应的Issue,你可以复制Issue的相关信息。 --> <!-- # Why? > 对应哪个issue? > 为什么要这个pull request? > 背景故事或原因是怎样的? > 你理解的业务需求是怎样的? --> <!-- # What? > 这是一个什么Pull Request? > 描述一下是什么? > 对哪些人有好处? --> <!-- # How? > 大概描述下,如何具体实现的这个Pull Request? --> # AI says <!-- AI auto review added here -->
- fix: #10510 - fix: #3979 <!-- This is an auto-generated comment: release notes by OSS CodeRabbit --> ### Summary by CodeRabbit - Style: Updated the CSS styles of the calendar picker input and time picker widget to modify the placeholder color. - Style: Removed the CSS style for the `::-webkit-input-placeholder` pseudo-element in the calendar picker input. - Style: Removed the CSS style for the placeholder text in the time picker input field and added a media query for responsive styling. - Style: Changed the background color and fill color of a widget error style using new CSS variables. - Documentation: No changes related to documentation were identified. - Refactor: No changes related to code logic or functionality were identified. - New Feature: Improved visual appearance and user experience by updating CSS styles. <!-- end of auto-generated comment: release notes by OSS CodeRabbit -->
# Human says As a human, what have you done for this pull request? Why? What? How? <!-- 如果这个Pull Request有对应的Issue,你可以复制Issue的相关信息。 --> <!-- # Why? > 对应哪个issue? > 为什么要这个pull request? > 背景故事或原因是怎样的? > 你理解的业务需求是怎样的? --> <!-- # What? > 这是一个什么Pull Request? > 描述一下是什么? > 对哪些人有好处? --> <!-- # How? > 大概描述下,如何具体实现的这个Pull Request? --> # AI says <!-- AI auto review added here --> <!-- This is an auto-generated comment: release notes by OSS CodeRabbit --> ### Summary by CodeRabbit - Bug Fix: The `CustomPage` component now correctly renders the `NoPermission` component when `role`, `shareId`, and `templateId` are all falsy. - Refactor: Imports were added for `createWidget` from `'api/widget/api'`, `TriggerCommands` from `'modules/shared/apphook/trigger_commands'`, and `EmitterEventName` from `'modules/shared/simple_emitter'`. The order of imports was also modified. <!-- end of auto-generated comment: release notes by OSS CodeRabbit -->
- fix: #10582 <!-- This is an auto-generated comment: release notes by OSS CodeRabbit --> ### Summary by CodeRabbit - Refactor: Removed unused import for `Message` and added import for `Tooltip` in `expand_record.tsx`. - Bug Fix: Modified `ExpandRecordMoreOption` component to render a menu item only if `fromCurrentDatasheet` is true, in addition to existing conditions. - Refactor: Removed import statement for `ButtonActionType` in `cell_helper.ts`. <!-- end of auto-generated comment: release notes by OSS CodeRabbit -->
- fix: #10793 - fix: #10996 - fix: #10995 - fix: #11004 - fix: #10998 <!-- This is an auto-generated comment: release notes by OSS CodeRabbit --> ### Summary by CodeRabbit - New Feature: Added `isWorkdocOpen` enum value and method for checking open records. - Refactor: Improved display of team member counts in components. - Enhancement: Updated property assignments in `MemberInfo` component. - New Feature: Introduced `isEditable` property for conditional component editability. - Enhancement: Optimized import statements and type definitions. - Bug Fix: Correctly decode email before API call for verification. - Refactor: Updated function signatures and data structures in components. <!-- end of auto-generated comment: release notes by OSS CodeRabbit -->
@coderabbitai: ignore Co-authored-by: Zoe <[email protected]>
close #10753
- fix: #10738 <!-- This is an auto-generated comment: release notes by OSS CodeRabbit --> ### Summary by CodeRabbit - New Feature: Introduce a `single` selection mode for improved user experience in node selection within the components. - Refactor: Enhance code readability by renaming variables and adding necessary imports. - New Feature: Enable passing down the `single` prop to enhance functionality in various components. <!-- end of auto-generated comment: release notes by OSS CodeRabbit -->
# Human says As a human, what have you done for this pull request? Why? What? How? <!-- 如果这个Pull Request有对应的Issue,你可以复制Issue的相关信息。 --> <!-- # Why? > 对应哪个issue? > 为什么要这个pull request? > 背景故事或原因是怎样的? > 你理解的业务需求是怎样的? --> <!-- # What? > 这是一个什么Pull Request? > 描述一下是什么? > 对哪些人有好处? --> <!-- # How? > 大概描述下,如何具体实现的这个Pull Request? --> # AI says <!-- AI auto review added here -->
…… (#11047) …ests # Human says As a human, what have you done for this pull request? Why? What? How? <!-- 如果这个Pull Request有对应的Issue,你可以复制Issue的相关信息。 --> <!-- # Why? > 对应哪个issue? > 为什么要这个pull request? > 背景故事或原因是怎样的? > 你理解的业务需求是怎样的? --> <!-- # What? > 这是一个什么Pull Request? > 描述一下是什么? > 对哪些人有好处? --> <!-- # How? > 大概描述下,如何具体实现的这个Pull Request? --> # AI says <!-- AI auto review added here --> <!-- This is an auto-generated comment: release notes by OSS CodeRabbit --> ### Summary by CodeRabbit - Bug Fix: Prevented double mounting of child components in `RouterProvider` to resolve issues with WeChat login caused by setting the language. Added a check for `locale` before rendering to ensure proper functionality. <!-- end of auto-generated comment: release notes by OSS CodeRabbit -->
…… (#11048) …ests # Human says As a human, what have you done for this pull request? Why? What? How? <!-- 如果这个Pull Request有对应的Issue,你可以复制Issue的相关信息。 --> <!-- # Why? > 对应哪个issue? > 为什么要这个pull request? > 背景故事或原因是怎样的? > 你理解的业务需求是怎样的? --> <!-- # What? > 这是一个什么Pull Request? > 描述一下是什么? > 对哪些人有好处? --> <!-- # How? > 大概描述下,如何具体实现的这个Pull Request? --> # AI says <!-- AI auto review added here --> <!-- This is an auto-generated comment: release notes by OSS CodeRabbit --> ### Summary by CodeRabbit - Bug Fix: Prevent double mounting of child components and potential issues with requests like WeChat login by adding a check for the `locale` variable before rendering in router_provider.tsx. This change enhances stability and user experience by addressing rendering inconsistencies. <!-- end of auto-generated comment: release notes by OSS CodeRabbit -->
@coderabbitai: ignore --------- Co-authored-by: Zoe <[email protected]>
# Human says As a human, what have you done for this pull request? Why? What? How? <!-- 如果这个Pull Request有对应的Issue,你可以复制Issue的相关信息。 --> <!-- # Why? > 对应哪个issue? > 为什么要这个pull request? > 背景故事或原因是怎样的? > 你理解的业务需求是怎样的? --> <!-- # What? > 这是一个什么Pull Request? > 描述一下是什么? > 对哪些人有好处? --> <!-- # How? > 大概描述下,如何具体实现的这个Pull Request? --> # AI says <!-- AI auto review added here --> <!-- This is an auto-generated comment: release notes by OSS CodeRabbit --> ### Summary by CodeRabbit - Style: Updated border and background styles for improved visual appearance in the `Card` component. - Refactor: Enhanced destructuring assignment of props and removed inline style setting in the `CardBody` component. - Style: Removed unnecessary `background-color` property from global CSS selector for cleaner styling. <!-- end of auto-generated comment: release notes by OSS CodeRabbit -->
- fix: #11026
- fix: #10810 - fix: #11027
- fix: #11069 <!-- This is an auto-generated comment: release notes by OSS CodeRabbit --> ### Summary by CodeRabbit - Bug Fix: Improved robustness of `getNodeViewWithoutFilterInfo` function by handling null `originView`, enhancing reliability for users. <!-- end of auto-generated comment: release notes by OSS CodeRabbit -->
- fix: 嵌入表设置列权限 crash <img width="728" alt="image" src="https://github.com/vikadata/vikadata/assets/6942517/5c3bdf4a-0f4d-4a23-b0dc-6705a078520c"> <!-- This is an auto-generated comment: release notes by OSS CodeRabbit --> ### Summary by CodeRabbit - Bug Fix: Improved error handling in `DisabledFieldPermission` component to prevent potential crashes when accessing `spaceInfo`. - Refactor: Updated handling of `spaceInfo` and `spaceId`, along with dispatching actions in `EnableFieldPermissionPlus` component. - Update: Made the `bucket` field optional in `baseAttachmentFieldSchema` for better flexibility. <!-- end of auto-generated comment: release notes by OSS CodeRabbit -->
# Human says As a human, what have you done for this pull request? Why? What? How? <!-- 如果这个Pull Request有对应的Issue,你可以复制Issue的相关信息。 --> <!-- # Why? > 对应哪个issue? > 为什么要这个pull request? > 背景故事或原因是怎样的? > 你理解的业务需求是怎样的? --> <!-- # What? > 这是一个什么Pull Request? > 描述一下是什么? > 对哪些人有好处? --> <!-- # How? > 大概描述下,如何具体实现的这个Pull Request? --> # AI says <!-- AI auto review added here --> <!-- This is an auto-generated comment: release notes by OSS CodeRabbit --> ### Summary by CodeRabbit - New Feature: Enhanced select fields to accept both numbers and strings for colors, providing more flexibility in customization options for users. <!-- end of auto-generated comment: release notes by OSS CodeRabbit -->
# Human says As a human, what have you done for this pull request? Why? What? How? <!-- 如果这个Pull Request有对应的Issue,你可以复制Issue的相关信息。 --> <!-- # Why? > 对应哪个issue? > 为什么要这个pull request? > 背景故事或原因是怎样的? > 你理解的业务需求是怎样的? --> <!-- # What? > 这是一个什么Pull Request? > 描述一下是什么? > 对哪些人有好处? --> <!-- # How? > 大概描述下,如何具体实现的这个Pull Request? --> # AI says <!-- AI auto review added here -->
# Human says As a human, what have you done for this pull request? Why? What? How? <!-- 如果这个Pull Request有对应的Issue,你可以复制Issue的相关信息。 --> <!-- # Why? > 对应哪个issue? > 为什么要这个pull request? > 背景故事或原因是怎样的? > 你理解的业务需求是怎样的? --> <!-- # What? > 这是一个什么Pull Request? > 描述一下是什么? > 对哪些人有好处? --> <!-- # How? > 大概描述下,如何具体实现的这个Pull Request? --> # AI says <!-- AI auto review added here -->
@coderabbitai: ignore Co-authored-by: Zoe <[email protected]>
ChambersChan
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@coderabbitai: ignore