Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the octets numbers from the chunked response for blueprint output #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove the octets numbers from the chunked response for blueprint output #8

wants to merge 1 commit into from

Conversation

eiri
Copy link

@eiri eiri commented Apr 29, 2015

Chunked transfer encoding format includes the number of the octets
of the data in each chunk as a part of the response.

This commit adds detection of the Transfer-Encoding: chunked
into the parser to strip the numbers from the output for blueprint
format. The output of raw format kept not modified.

This fix probably also resolves issue #6.

Chunked transfer encoding format includes the number of the octets
of the data in each chunk as a part of the response.

This commit adds detection of the `Transfer-Encoding: chunked`
into the parser to strip the numbers from the output for blueprint
format. The output of raw format kept not modified.

This fix probably also resolves issue #6.
@netmilk
Copy link
Contributor

netmilk commented Apr 30, 2015

Hi @eiri, it's awesome that you're using curl-trace-parser and thank you very much for the contribution!

I'm happy to merge it, but can you please add a tracefile to the fixtures for this particular situation and add a simple test for it? It will help to keep this feature maintained in the future and to don't brake it. :)

Also I think that some servers can send transfer-encoding header with capital T and E, so it will not match the regexp.

An I suggest to do this action on the parsed HTTP response instead of blob data in parsed response, because there is an access to parsed headers, so it shouldn't be implemented with use of regex but with plain JS equation. What you think?

@bf4
Copy link

bf4 commented Aug 26, 2016

@eiri You still working on this?

@honzajavorek
Copy link
Contributor

@eiri Hi, would you have time to get back to this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants