Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated has_rdoc from gemspec #2978

Merged

Conversation

larouxn
Copy link
Contributor

@larouxn larouxn commented May 17, 2024

This change simply removes the deprecated has_rdoc usage from the gemspec. Due to this deprecated usage end users will see the following message in their console at times. Would be ideal if we can remove this noise.

NOTE: Gem::Specification#has_rdoc= is deprecated with no replacement. It will be removed in Rubygems 4
Gem::Specification#has_rdoc= called from /Users/larouxn/.gem/ruby/ruby-3.3.0/bundler/gems/thrift-b109bdd1a4aa/lib/rb/thrift.gemspec:15.

Looks like it has been deprecated for at least 5 years based on tickets raised about this back in ~2018.

Screenshot 2024-05-17 at 11 08 56
  • Did you create an Apache Jira ticket? (Request account here, not required for trivial changes) - I did not create a ticket.
  • If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"? - N/A, see above.
  • Did you squash your changes to a single commit? (not required, but preferred)
  • Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

@larouxn larouxn marked this pull request as ready for review May 17, 2024 03:08
@fishy fishy added the ruby label May 17, 2024
@Jens-G Jens-G merged commit b429cc9 into apache:master May 17, 2024
25 of 34 checks passed
@larouxn larouxn deleted the remove_deprecated_has_rdoc_from_gemspec branch May 18, 2024 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants