Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump org.apache.derby:derby from 10.14.2.0 to 10.17.1.0 #1947

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 20, 2023

Bumps org.apache.derby:derby from 10.14.2.0 to 10.17.1.0.

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Nov 20, 2023
@j143 j143 added this to the systemds-3.2.0 milestone Dec 17, 2023
@j143
Copy link
Contributor

j143 commented Dec 26, 2023

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/maven/org.apache.derby-derby-10.17.1.0 branch from 0a920c3 to c3e9b08 Compare December 26, 2023 04:18
@j143
Copy link
Contributor

j143 commented Dec 26, 2023

need to confirm java jdk version and maven compiler plugin version supports this Derby

we are using actions java version 11.

perhaps, we could upgrade to other versions
https://github.com/actions/setup-java#setup-java

23/12/26 04:29:38 WARN util.NativeCodeLoader: Unable to load native-hadoop library for your platform... using builtin-java classes where applicable
[INFO] Tests run: 12, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 8.206 s - in org.apache.sysds.test.functions.data.tensor.TensorTextCellParallelTest
[INFO] Running org.apache.sysds.test.functions.data.tensor.SqlTest
23/12/26 04:29:48 WARN util.NativeCodeLoader: Unable to load native-hadoop library for your platform... using builtin-java classes where applicable
Error:  Tests run: 12, Failures: 0, Errors: 12, Skipped: 0, Time elapsed: 2.106 s <<< FAILURE! - in org.apache.sysds.test.functions.data.tensor.SqlTest
Error:  org.apache.sysds.test.functions.data.tensor.SqlTest.sqlTestHybrid[0]  Time elapsed: 2.07 s  <<< ERROR!
java.lang.RuntimeException: java.sql.SQLException: No suitable driver found for jdbc:derby:memory:derbyDB;create=true
	at org.apache.sysds.test.functions.data.tensor.SqlTest.testSql(SqlTest.java:98)
	at org.apache.sysds.test.functions.data.tensor.SqlTest.sqlTestHybrid(SqlTest.java:77)
Caused by: java.sql.SQLException: No suitable driver found for jdbc:derby:memory:derbyDB;create=true
	at org.apache.sysds.test.functions.data.tensor.SqlTest.testSql(SqlTest.java:95)
	at org.apache.sysds.test.functions.data.tensor.SqlTest.sqlTestHybrid(SqlTest.java:77)

Ref: https://lists.apache.org/thread/tjcn6xh6gqsy1tvkfx9f862mmm085r4x

@Baunsgaard
Copy link
Contributor

we can consider updating to the same version as spark use : <derby.version>10.16.1.1</derby.version>
I think we have to take the same decisions anyway with regards to this dependency.
and 10.16.1.1 is considered "safe" for java 11 as i understand it.

@j143
Copy link
Contributor

j143 commented Jan 21, 2024

https://github.com/dependabot rebase

Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 21, 2024

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@j143
Copy link
Contributor

j143 commented Jan 21, 2024

@dependabot recreate

Bumps org.apache.derby:derby from 10.14.2.0 to 10.17.1.0.

---
updated-dependencies:
- dependency-name: org.apache.derby:derby
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/maven/org.apache.derby-derby-10.17.1.0 branch from 3c413a5 to e3ec921 Compare January 21, 2024 14:20
@j143
Copy link
Contributor

j143 commented Jan 21, 2024

we can consider updating to the same version as spark use : <derby.version>10.16.1.1</derby.version> I think we have to take the same decisions anyway with regards to this dependency. and 10.16.1.1 is considered "safe" for java 11 as i understand it.

right.

The 10.17.1.0 may not work for us.

The chief feature of this release is the removal of calls to deprecated
Java APIs. Derby 10.17.1.0 has been built and tested on the Java SE 21
platform, and will run only on Java SE 21 and newer Java platforms.
Derby 10.17.1.0 cannot be used with older Java platforms.

[1] Derby 10.17.1.0 release mail: https://lists.apache.org/thread/vjl42y0p86c7lh7lsm3bfth6dx83nhb8

@j143
Copy link
Contributor

j143 commented Jan 22, 2024

Hi @Baunsgaard

Error 1
https://github.com/apache/systemds/actions/runs/7602712390/job/20703588777#logs

WARNING: Illegal reflective access by io.netty.handler.ssl.util.OpenJdkSelfSignedCertGenerator (file:/root/.m2/repository/io/netty/netty-handler/4.1.96.Final/netty-handler-4.1.96.Final.jar) to method sun.security.x509.X509CertInfo.set(java.lang.String,java.lang.Object)
WARNING: Please consider reporting this to the maintainers of io.netty.handler.ssl.util.OpenJdkSelfSignedCertGenerator

Error 2
Error: Tests run: 4, Failures: 0, Errors: 3, Skipped: 1, Time elapsed: 1.766 s <<< FAILURE! - in org.apache.sysds.test.functions.federated.monitoring.FederatedWorkerStatisticsTest
Error: org.apache.sysds.test.functions.federated.monitoring.FederatedWorkerStatisticsTest.testWorkerStatisticsReturnedForMonitoring Time elapsed: 1.733 s <<< ERROR!
java.lang.RuntimeException: java.sql.SQLException: No suitable driver found for jdbc:derby:memory:derbyDB;create=true

The derby jar is present in the lib, but still seeing this issue. Any pointers on these?

Regards.

@Baunsgaard
Copy link
Contributor

Hi @Baunsgaard

Error 1 https://github.com/apache/systemds/actions/runs/7602712390/job/20703588777#logs

WARNING: Illegal reflective access by io.netty.handler.ssl.util.OpenJdkSelfSignedCertGenerator (file:/root/.m2/repository/io/netty/netty-handler/4.1.96.Final/netty-handler-4.1.96.Final.jar) to method sun.security.x509.X509CertInfo.set(java.lang.String,java.lang.Object) WARNING: Please consider reporting this to the maintainers of io.netty.handler.ssl.util.OpenJdkSelfSignedCertGenerator

Error 2 Error: Tests run: 4, Failures: 0, Errors: 3, Skipped: 1, Time elapsed: 1.766 s <<< FAILURE! - in org.apache.sysds.test.functions.federated.monitoring.FederatedWorkerStatisticsTest Error: org.apache.sysds.test.functions.federated.monitoring.FederatedWorkerStatisticsTest.testWorkerStatisticsReturnedForMonitoring Time elapsed: 1.733 s <<< ERROR! java.lang.RuntimeException: java.sql.SQLException: No suitable driver found for jdbc:derby:memory:derbyDB;create=true

The derby jar is present in the lib, but still seeing this issue. Any pointers on these?

Regards.

Unfortunately, I do not know.

@j143
Copy link
Contributor

j143 commented Jan 23, 2024

sure, will take a deeper look. the existing derby is a bit too old.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file java Pull requests that update Java code
Projects
Status: In Progress
2 participants