refactor: Migration of AnnotationLayerControl to TypeScript #28346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-bodley
changed the title
justinpark
reviewed
May 8, 2024
Comment on lines
83
to
98
| export interface Explore { | ||
| can_add: boolean; | ||
| can_download: boolean; | ||
| can_overwrite: boolean; | ||
| isDatasourceMetaLoading: boolean; | ||
| isStarred: boolean; | ||
| triggerRender: boolean; | ||
| datasource: Dataset; | ||
| controls: ControlStateMapping; | ||
| form_data: QueryFormData; | ||
| slice: Slice; | ||
| controlsTransferred: string[]; | ||
| standalone: boolean; | ||
| force: boolean; | ||
| common: JsonObject; | ||
| } |
There was a problem hiding this comment.
Please reuse the ExplorePageState['explore'] type in `src/explore/types' to minimize the maintainance.
9 tasks
justinpark
reviewed
May 9, 2024
superset-frontend/src/explore/components/controls/AnnotationLayerControl/index.tsx
Outdated
Show resolved
Hide resolved
justinpark
reviewed
May 9, 2024
superset-frontend/src/explore/components/controls/AnnotationLayerControl/index.tsx
Outdated
Show resolved
Hide resolved
justinpark
reviewed
May 9, 2024
superset-frontend/src/explore/components/controls/AnnotationLayerControl/index.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: JUST.in DO IT <[email protected]>
Co-authored-by: JUST.in DO IT <[email protected]>
Co-authored-by: JUST.in DO IT <[email protected]>
geido
reviewed
May 16, 2024
Comment on lines
+55
to
+58
| annotation: any; | ||
| timeout: any; | ||
| key: any; | ||
| formData?: any; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Migrate AnnotationLayerControl to TypeScript
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N.A
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION