fix(ci): correct input type for allow-dependencies-licenses in Dependency Review GH action
#28343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…endency Review GH action Signed-off-by: hainenber <[email protected]>
hainenber
requested review from
villebro,
geido,
eschutho,
rusackas,
betodealmeida,
nytai,
mistercrunch,
craig-rueda,
john-bodley,
kgabryje and
dpgaspar
as code owners
github-actions
bot
added
the
github_actions
mistercrunch
approved these changes
May 6, 2024
mistercrunch
added a commit
that referenced
this pull request
May 6, 2024
#28343 fixes an issue where I had broken a specific github action workflow in a previous PR without realizing I did. If/when altering the yaml, if the yaml itsefl is valid (we have a check for that) yet the schema is not - either through passing the right data structure or required types, the action just won't run and the PR is still mergeable. The failure gets somewhat burried on the Actions tab (at the bottom of https://github.com/apache/superset/actions) Here I'm hoping that this pre-commit hook will both catch this early, and prevent the PR from being mergeable. Find out more about the hook here: https://github.com/mpalmer/action-validator
|
Hoping #28358 will prevent similar troubles |
john-bodley
reviewed
May 6, 2024
| # license: https://applitools.com/legal/open-source-terms-of-use/ | ||
| # pkg:npm/[email protected] | ||
| # selecting BSD-3-Clause licensing terms for node-forge to ensure compatibility with Apache | ||
| allow-dependencies-licenses: pkg:npm/[email protected], pkg:npm/applitools/core, pkg:npm/applitools/core-base, pkg:npm/applitools/css-tree, pkg:npm/applitools/ec-client, pkg:npm/applitools/eg-socks5-proxy-server, pkg:npm/applitools/eyes, pkg:npm/applitools/eyes-cypress, pkg:npm/applitools/nml-client, pkg:npm/applitools/tunnel-client, pkg:npm/applitools/utils, pkg:npm/[email protected] |
There was a problem hiding this comment.
Any reason to switch from multiline to single line? This seems less readable and harder to review future changes if only one dependency changes.
There was a problem hiding this comment.
The GH action only accepts the input arg as single line. Maybe it will get fixed in the future version but for now, it's the only way proceeding
imancrsrk
pushed a commit
to imancrsrk/superset
that referenced
this pull request
May 10, 2024
…ndency Review GH action (apache#28343) Signed-off-by: hainenber <[email protected]>
jzhao62
pushed a commit
to jzhao62/superset
that referenced
this pull request
May 16, 2024
…ndency Review GH action (apache#28343) Signed-off-by: hainenber <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(ci): correct input type for
allow-dependencies-licensesfor Dependency Review GH actionSUMMARY
Some of my PRs got failed in the GH action due to incorrect input type for said GH action. This change is to restore the CI job's functionality.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before
After
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION