Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(build): uplift webpack-related packages to v5 #28342

Merged

Conversation

hainenber
Copy link
Contributor

chore(build): uplift webpack-related packages to webpack5-supported version

SUMMARY

Uplift the webpack-related packages to webpack5-supported version for currency and fix any associated vulnerabilities.
There's a small config refactor in superset-frontend's webpack.config.js made by following webpack-dev-server's migration guide

I run npm run dev, npm run build and npm run dev-server and all things look good.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

Run npm run dev, npm run build-dev and npm run dev-server

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@hainenber hainenber changed the title chore(build): uplift webpack-related packages to v5 chore(build): uplift webpack-related packages to v5 May 4, 2024
@rusackas rusackas requested a review from kgabryje May 6, 2024 22:25
Copy link
Member

@kgabryje kgabryje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label May 8, 2024
@kgabryje kgabryje merged commit 8c27d4d into apache:master May 8, 2024
28 checks passed
kgabryje added a commit to kgabryje/incubator-superset that referenced this pull request May 8, 2024
@michael-s-molina
Copy link
Member

@hainenber @kgabryje It looks like the correct way of implementing the desired behavior is to use the afterEmit compiler hook instead of a middleware.

imancrsrk pushed a commit to imancrsrk/superset that referenced this pull request May 10, 2024
imancrsrk pushed a commit to imancrsrk/superset that referenced this pull request May 10, 2024
@hainenber hainenber deleted the uplift-webpack-related-packages-to-v5 branch May 12, 2024 06:05
jzhao62 pushed a commit to jzhao62/superset that referenced this pull request May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies:npm embedded lgtm This PR has been approved by a maintainer size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants