Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add Apache Spark Jinja template processor #28335

Merged

Conversation

john-bodley
Copy link
Member

@john-bodley john-bodley commented May 3, 2024

SUMMARY

Somewhat akin to adding the Trino Jinja template processor, this PR adds a Spark Jinja template processor to provide access to the latest[_sub]_partition et al. macros. Similar to Trino (where people may have migrated from Presto), the Spark processor provides backwards compatibility from Hive.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

Added unit tests.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@john-bodley john-bodley added the review:checkpoint Last PR reviewed during the daily review standup label May 3, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.04%. Comparing base (2e5f3ed) to head (e843fd3).
Report is 29 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #28335      +/-   ##
==========================================
+ Coverage   60.49%   70.04%   +9.55%     
==========================================
  Files        1931     1933       +2     
  Lines       76241    76502     +261     
  Branches     8566     8566              
==========================================
+ Hits        46122    53587    +7465     
+ Misses      28015    20811    -7204     
  Partials     2104     2104              
Flag Coverage Δ
hive 49.21% <37.50%> (+0.04%) ⬆️
mysql 77.57% <100.00%> (?)
postgres 77.68% <100.00%> (?)
presto 53.83% <37.50%> (+0.03%) ⬆️
python 83.26% <100.00%> (+19.78%) ⬆️
sqlite 77.15% <100.00%> (?)
unit 57.72% <37.50%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@john-bodley john-bodley marked this pull request as ready for review May 3, 2024 17:26
@john-bodley john-bodley merged commit 27c93f4 into apache:master May 6, 2024
44 of 52 checks passed
@john-bodley john-bodley removed review:draft review:checkpoint Last PR reviewed during the daily review standup labels May 6, 2024
imancrsrk pushed a commit to imancrsrk/superset that referenced this pull request May 10, 2024
jzhao62 pushed a commit to jzhao62/superset that referenced this pull request May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants