fix: Small tweaks for Line and Area chart migrations (ECharts) #28334
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes some issues found while testing Line and Area chart migrations (ECharts) using Airbnb's production data:
groupby
is an array. Even though the Typescript definition does not allownull
values, legacy charts might have them. Check fix: Ensures form data required properties exist at runtime (echarts-timeseries) #25419 for more context about this problem.TESTING INSTRUCTIONS
CI is sufficient as I'm already testing the migrations with a lot of data.
ADDITIONAL INFORMATION