[feature][datasource] Main add datasource-pulsar #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wachoo
changed the title
wachoo
force-pushed
the
dev
branch
5 times, most recently
from
6a623de
to
2766026
Compare
wachoo
force-pushed
the
dev
branch
3 times, most recently
from
7aae9cd
to
c4632ff
Compare
EricJoy2048
previously approved these changes
Nov 13, 2023
| @@ -479,7 +524,7 @@ | |||
| <groupId>mysql</groupId> | |||
| <artifactId>mysql-connector-java</artifactId> | |||
| <version>${mysql.version}</version> | |||
| <scope>test</scope> | |||
| <scope>provided</scope> | |||
There was a problem hiding this comment.
mysql-connector-java license is GPL, So, must use scope test here.
There was a problem hiding this comment.
I help update the pom.xml
There was a problem hiding this comment.
thx, Merging is still blocked.
wachoo
force-pushed
the
dev
branch
5 times, most recently
from
9d4689d
to
7878821
Compare
haha, thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
Check list
New License Guide