Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature][datasource] Main add datasource-pulsar #145

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

wachoo
Copy link
Contributor

@wachoo wachoo commented Nov 2, 2023

Purpose of this pull request

Check list

@wachoo wachoo changed the title add datasource-pulsar [feature][datasource] Main add datasource-pulsar Nov 2, 2023
EricJoy2048
EricJoy2048 previously approved these changes Nov 13, 2023
@@ -479,7 +524,7 @@
<groupId>mysql</groupId>
<artifactId>mysql-connector-java</artifactId>
<version>${mysql.version}</version>
<scope>test</scope>
<scope>provided</scope>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mysql-connector-java license is GPL, So, must use scope test here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx,I got it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I help update the pom.xml

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx, Merging is still blocked.

davidzollo
davidzollo previously approved these changes Dec 28, 2023
Copy link
Contributor

@davidzollo davidzollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
LGTM

@wachoo
Copy link
Contributor Author

wachoo commented Mar 9, 2024

+1 LGTM

haha, thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants