Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QPID-7148: Use more modern CMake install machinery for better QpidConfig.cmake #33

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

@jiridanek
Copy link
Contributor Author

jiridanek commented Oct 22, 2022

TODO

@jiridanek jiridanek self-assigned this Oct 22, 2022
@jiridanek
Copy link
Contributor Author

It appears that this really fixes the build for me rh-messaging/cli-cpp#71

The issue is that Bazel moves the installed library around, and requires QpidConfig.cmake to contain relative paths. Otherwise, attempt is made to fetch libraries from original install location, which is prevented by Bazel sandbox and therefore build fails.

@jiridanek
Copy link
Contributor Author

As far as I can remember, federation tests are broken and failure can be ignored

6: federation.FederationTests.test_dynamic_direct_shared_queue ............. fail
6: Error during test:  Traceback (most recent call last):
6:     File "/home/travis/.local/bin/qpid-python-test", line 340, in run
6:       phase()
6:     File "/home/travis/build/apache/qpid-cpp/Build/src/tests/federation.py", line 2592, in test_dynamic_direct_shared_queue
6:       self.assertNotEqual(_c.msgsToClient, 0, "Messages did not pass over link as expected.")
6:     File "/usr/lib/python2.7/unittest/case.py", line 522, in assertNotEqual
6:       raise self.failureException(msg)
6:   AssertionError: Messages did not pass over link as expected.

https://app.travis-ci.com/github/apache/qpid-cpp/builds/256978344#L2108

@jiridanek jiridanek changed the title QPID-7148 Use more modern CMake install machinery for better QpidConfig.cmake QPID-7148: Use more modern CMake install machinery for better QpidConfig.cmake Apr 8, 2023
@jiridanek jiridanek force-pushed the jd_2022_10_22_qpid_7148_QpidConfig.cmake branch from f8ed352 to e781482 Compare April 8, 2023 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant