Bug: Auto sizing not working properly due to rounding error when calculating defaultCharWidth #541
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The XSSFSheet#autoSizeColumn method doesn't work properly for some specific cell values and font metrics.
The following code snippet is an example for this behavior:
Generated excel file:
The bug is caused by a rounding error in SheetUtil#getDefaultCharWidth:
poi/poi/src/main/java/org/apache/poi/ss/util/SheetUtil.java
Lines 301 to 302 in 5533d35
Rounding is not necessary at all, removing the operation and converting the return type of getDefaultCharWidth() to double solves the issue.
The column width calculation that causes the error (and uses a value returned by SheetUtil#getDefaultCharWidth) occurs in SheetUtil#getCellWidth:
poi/poi/src/main/java/org/apache/poi/ss/util/SheetUtil.java
Line 244 in 5533d35