Adding config for having suffix for client ID for realtime consumer #13168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #13168 +/- ##
============================================
+ Coverage 61.75% 62.23% +0.48%
+ Complexity 207 198 -9
============================================
Files 2436 2529 +93
Lines 133233 138268 +5035
Branches 20636 21393 +757
============================================
+ Hits 82274 86054 +3780
- Misses 44911 45796 +885
- Partials 6048 6418 +370
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Jackie-Jiang
added
ingestion
real-time
documentation
Configuration
Jackie-Jiang
approved these changes
May 18, 2024
pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java
Outdated
Show resolved
Hide resolved
pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java
Outdated
Show resolved
Hide resolved
pinot-spi/src/main/java/org/apache/pinot/spi/config/instance/InstanceDataManagerConfig.java
Outdated
Show resolved
Hide resolved
|
Thanks for the review and approval @Jackie-Jiang . I have addressed the comments . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
For the consuming source of Pinot this can be used to give more which specify like consuming server is having issue.
As currently the info is _tableNameWithType, streamTopic, _partitionGroupId which is going to be the same for all the replicas of the consuming real-time segment.
Using this config can be used to provide more granular info which can used to speed up debugging.
Tags
Todo