reduce regex pattern compilation in Pinot jdbc #13138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #13138 +/- ##
============================================
+ Coverage 61.75% 62.16% +0.40%
+ Complexity 207 198 -9
============================================
Files 2436 2517 +81
Lines 133233 137898 +4665
Branches 20636 21340 +704
============================================
+ Hits 82274 85719 +3445
- Misses 44911 45793 +882
- Partials 6048 6386 +338
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Ready for review. |
Jackie-Jiang
approved these changes
May 15, 2024
pinot-clients/pinot-jdbc-client/src/main/java/org/apache/pinot/client/utils/DriverUtils.java
Outdated
Show resolved
Hide resolved
pinot-clients/pinot-jdbc-client/src/main/java/org/apache/pinot/client/utils/DriverUtils.java
Outdated
Show resolved
Hide resolved
sullis
force-pushed
the
sean/regex-pattern-compile-jdbc
branch
from
603292b
to
790fa8d
Compare
|
Ready for review. |
sullis
force-pushed
the
sean/regex-pattern-compile-jdbc
branch
from
790fa8d
to
aad8798
Compare
|
fixed a checkstyle violation. |
sullis
force-pushed
the
sean/regex-pattern-compile-jdbc
branch
from
aad8798
to
9227922
Compare
sullis
force-pushed
the
sean/regex-pattern-compile-jdbc
branch
from
9227922
to
0239fb9
Compare
|
ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference
https://www.baeldung.com/java-regex-pre-compile