Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade orc to 2.0.1 #13135

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

upgrade orc to 2.0.1 #13135

wants to merge 1 commit into from

Conversation

sullis
Copy link
Contributor

@sullis sullis commented May 12, 2024

@codecov-commenter
Copy link

codecov-commenter commented May 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.17%. Comparing base (59551e4) to head (1b5fb9a).
Report is 511 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #13135      +/-   ##
============================================
+ Coverage     61.75%   62.17%   +0.42%     
+ Complexity      207      198       -9     
============================================
  Files          2436     2534      +98     
  Lines        133233   139016    +5783     
  Branches      20636    21541     +905     
============================================
+ Hits          82274    86432    +4158     
- Misses        44911    46126    +1215     
- Partials       6048     6458     +410     
Flag Coverage Δ
custom-integration1 <0.01% <ø> (-0.01%) ⬇️
integration <0.01% <ø> (-0.01%) ⬇️
integration1 <0.01% <ø> (-0.01%) ⬇️
integration2 0.00% <ø> (ø)
java-11 46.62% <ø> (-15.09%) ⬇️
java-21 62.06% <ø> (+0.43%) ⬆️
skip-bytebuffers-false 62.15% <ø> (+0.40%) ⬆️
skip-bytebuffers-true 62.02% <ø> (+34.29%) ⬆️
temurin 62.17% <ø> (+0.42%) ⬆️
unittests 62.16% <ø> (+0.42%) ⬆️
unittests1 46.69% <ø> (-0.20%) ⬇️
unittests2 27.82% <ø> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sullis sullis changed the title upgrade orc to 2.0.0 upgrade orc to 2.0.1 May 29, 2024
@sullis
Copy link
Contributor Author

sullis commented May 29, 2024

CI Build failure:

class file has wrong version 61.0, should be 55.0

@Jackie-Jiang
Copy link
Contributor

I guess ORC 2.0+ removed the support for Java 11, thus we cannot upgrade it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants