Adding a cluster config to enable instance pool and replica group configuration in table config

[soumitra-st]

Added an insteance level configuration instance.pool.and.replica.group.check to enable instance pool and replica group configuration check in table config.

If a Pinot cluster is configured with server pools to restart the cluster faster, then enabling instance.pool.and.replica.group.check config will enforce all tables are using Pool-Based Instance Assignment and Replica-Group Segment Assignment .

feature

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 82.14286% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 62.24%. Comparing base (59551e4) to head (5318366).
Report is 485 commits behind head on master.

Files	Patch %	Lines
...he/pinot/segment/local/utils/TableConfigUtils.java	68.75%	3 Missing and 2 partials ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##             master   #13131      +/-   ##
============================================
+ Coverage     61.75%   62.24%   +0.49%     
+ Complexity      207      198       -9     
============================================
  Files          2436     2531      +95     
  Lines        133233   138588    +5355     
  Branches      20636    21454     +818     
============================================
+ Hits          82274    86271    +3997     
- Misses        44911    45879     +968     
- Partials       6048     6438     +390     

Flag	Coverage Δ
custom-integration1	<0.01% <0.00%> (-0.01%)	⬇️
integration	<0.01% <0.00%> (-0.01%)	⬇️
integration1	<0.01% <0.00%> (-0.01%)	⬇️
integration2	0.00% <0.00%> (ø)
java-11	62.19% <82.14%> (+0.48%)	⬆️
java-21	62.12% <82.14%> (+0.50%)	⬆️
skip-bytebuffers-false	62.23% <82.14%> (+0.49%)	⬆️
skip-bytebuffers-true	62.09% <82.14%> (+34.36%)	⬆️
temurin	62.24% <82.14%> (+0.49%)	⬆️
unittests	62.24% <82.14%> (+0.49%)	⬆️
unittests1	46.71% <0.00%> (-0.18%)	⬇️
unittests2	27.92% <82.14%> (+0.18%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Jackie-Jiang]

Let's not keep adding booleans for each check type because it is hard to maintain. Suggest making them static, and set them up when starting the controller. validate() only takes tableConfig, schema and optional typesToSkip

[soumitra-st]

TableConfigUtils has static utility methods only. IMO, we should not store state as static variables in that class.

[Jackie-Jiang]

These are always instance level/cluster level config, so it should be good to have them as static (basically model it as a singleton validator). We may add 2 static methods setDisableGroovy() and setEnforcePoolBasedAssignment(), and set them up in the ControllerStarter.