HDDS-2643. TestOzoneDelegationTokenSecretManager#testRenewTokenFailureRenewalTime fails intermittently #6688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sadanand48
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
TestOzoneDelegationTokenSecretManager#testRenewTokenFailureRenewalTime fails intermittently
There is 'OzoneDelegationTokenSecretManager.run()' check every five seconds(or lesser if value is configured) for the expired tokens to be removed from the cache and in rare scenario if our thread doesn't get control before it, the expired token may get out of cache and hence will have to consider this as a valid scenario. I have modified the code to accommodate that condition. We are testing the exceptions to be thrown as part of this test method.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-2643
How was this patch tested?
Tested the modified code with 500 runs having 25 splits and 20 iterations, it is working 100% fine https://github.com/raju-balpande/apache_ozone/actions/runs/9114752214