HDDS-10273. Intermittent build failure while downloading NodeJS #6686
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is the second attempt to fix intermittent failures caused by unreliable download from
nodejs.org
.Changes from previous attempt (#6664, which was reverted):
curl
manually, because--retry
does not seem to work if connection is closed during download (example).nodejs.org
.mvn
command for populating the majority of the cache, only download of NodeJS is in separate shell script. This reduces change againstmaster
, makes it easier to test download of NodeJS separately, and simplifies RC handling a bit.cache/save
refuses to overwrite it on next run. In this case CI will use earlier versions of the cache.https://issues.apache.org/jira/browse/HDDS-10273
How was this patch tested?
Successful run of
populate-cache
:https://github.com/adoroszlai/ozone/actions/runs/9110100989/job/25044393656
Ozone build using cache from run above:
populate-cache
for same set of POM files (cache hit):https://github.com/adoroszlai/ozone/actions/runs/9111670296/job/25049278359
populate-cache
with failure (induced by addingexit 1
) does not save cache:https://github.com/adoroszlai/ozone/actions/runs/9111209051/job/25047846517