Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDDS-10273. Intermittent build failure while downloading NodeJS #6686

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

adoroszlai
Copy link
Contributor

What changes were proposed in this pull request?

This is the second attempt to fix intermittent failures caused by unreliable download from nodejs.org.

Changes from previous attempt (#6664, which was reverted):

  1. Retry curl manually, because --retry does not seem to work if connection is closed during download (example).
  2. Also store NodeJS in its own cache to reduce the need to download from nodejs.org.
  3. Restored previous inline mvn command for populating the majority of the cache, only download of NodeJS is in separate shell script. This reduces change against master, makes it easier to test download of NodeJS separately, and simplifies RC handling a bit.
  4. Avoid saving partial cache, because cache/save refuses to overwrite it on next run. In this case CI will use earlier versions of the cache.

https://issues.apache.org/jira/browse/HDDS-10273

How was this patch tested?

Successful run of populate-cache:
https://github.com/adoroszlai/ozone/actions/runs/9110100989/job/25044393656

Ozone build using cache from run above:

populate-cache for same set of POM files (cache hit):
https://github.com/adoroszlai/ozone/actions/runs/9111670296/job/25049278359

populate-cache with failure (induced by adding exit 1) does not save cache:
https://github.com/adoroszlai/ozone/actions/runs/9111209051/job/25047846517

@adoroszlai adoroszlai added the CI label May 16, 2024
@adoroszlai adoroszlai self-assigned this May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant