HDDS-10855. Handle Null ParentKeyInfo Error in Recon Namespace Summary Task.

[ArafatKhan2198]

What changes were proposed in this pull request?

This pull request fixes the Null ParentKeyInfo error that occurs during the Namespace Summary task in Recon. The error happens when the parent key information is missing. The update adds better logging and skips the creation of NSSummary for keys with missing parent info, so the task can continue processing other keys without stopping.

The error was causing the task to fail whenever it couldn't find the parent directory information. This could happen if the parent was deleted or not yet added to the database. By skipping these problematic keys and logging a warning, the task can keep running smoothly.

Approach:

• Added detailed logging when the parent key info is missing.
• Modified methods to throw an exception if the parent info is not found.
• Updated processing methods to catch this exception, log it, and skip the creation of NSSummary for those keys.
• Modified the handleDeleteKeyEvent to pick up the parent ID from the NSSummary object.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-10855

How was this patch tested?

[devmadhuu]

Thanks @ArafatKhan2198 for working on this patch. Have some comments. Pls check.

[devmadhuu]

Not very clear why we have taken parent Id from NSSummary object based. What was the issue in earlier code if we directly take parentObjectId from OmKeyInfo here ?

[devmadhuu]

Same warn message we are logging in setParentBucketId method also. processWithObjectStoreLayout is the caller of setParentBucketId, can we log different message which can mention what that caller is doing.

[devmadhuu]

Same warn message we are logging in setKeyParentID method also. processWithFileSystemLayout is the caller of setKeyParentID, can we log different message which can mention what that caller is doing.

[dombizita]

I couldn't find any logging in the setKeyParentID method, only the IOException is there.

ozone/hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/tasks/NSSummaryTaskWithLegacy.java

Lines 308 to 335 in 00f89e6

	private void setKeyParentID(OmKeyInfo keyInfo) throws IOException {
	String[] keyPath = keyInfo.getKeyName().split(OM_KEY_PREFIX);
	// If the path contains only one key then keyPath.length
	// will be 1 and the parent will be a bucket.
	// If the keyPath.length is greater than 1 then
	// there is at least one directory.
	if (keyPath.length > 1) {
	String[] dirs = Arrays.copyOf(keyPath, keyPath.length - 1);
	String parentKeyName = String.join(OM_KEY_PREFIX, dirs);
	parentKeyName += OM_KEY_PREFIX;
	String fullParentKeyName =
	getReconOMMetadataManager().getOzoneKey(keyInfo.getVolumeName(),
	keyInfo.getBucketName(), parentKeyName);
	OmKeyInfo parentKeyInfo = getReconOMMetadataManager()
	.getKeyTable(LEGACY_BUCKET_LAYOUT)
	.getSkipCache(fullParentKeyName);
	if (parentKeyInfo != null) {
	keyInfo.setParentObjectID(parentKeyInfo.getObjectID());
	} else {
	throw new IOException("ParentKeyInfo for " +
	"NSSummaryTaskWithLegacy is null");
	}
	} else {
	setParentBucketId(keyInfo);
	}
	}