Update helm to make secret instead of configmap for Nginx External Cert usage #716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
attempt to pipe value to .Files.Get - configmap `{{.Release.Name}}-gen-certs` is empty for tls cert and key when using nodeport and when using external cert for nginx
if user passes in external cert, do not store key in config map, store in secret
convert {{ .Release.Name }}-gen-certs from configMap to secret
dgrove-oss
approved these changes
Nov 12, 2021
|
Closing & reopening to kick travis |
|
Trying to kick travis again... |
|
Kicking travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my quest to use my own certs with an internal CA, and with some great help from @style95 I was able to make significant headway and get my deployment working as desired. I did want to make a small tweak so the external cert for nginx is not stored as a configmap, but instead as a secret. (I realize there's not a ton of difference under the hood but it helps me sleep better at night) I have not tested this with any other deployment types, so feel free to give any feedback as needed.