Add flexibility to configure grafana #615
Conversation
|
Hi @dgrove-oss, who could take a look at my PR? The idea would be to move the environment variables from the deployment template to the values file to give it more flexibility. |
There was a problem hiding this comment.
This looks plausible to me, but I don't use grafana at all myself. @selfxp -- any thoughts?
helm/openwhisk/values.yaml
Outdated
| @@ -335,6 +335,10 @@ grafana: | |||
| - https://raw.githubusercontent.com/apache/openwhisk/master/core/monitoring/user-events/compose/grafana/dashboards/openwhisk_events.json | |||
| - https://raw.githubusercontent.com/apache/openwhisk/master/core/monitoring/user-events/compose/grafana/dashboards/global-metrics.json | |||
| - https://raw.githubusercontent.com/apache/openwhisk/master/core/monitoring/user-events/compose/grafana/dashboards/top-namespaces.json | |||
| # https://grafana.com/docs/grafana/latest/administration/configuration/#configure-with-environment-variables | |||
| env: | |||
| - name: "TEST" | |||
There was a problem hiding this comment.
I think now, it would be good to move the default env to this section in values.yaml.
There was a problem hiding this comment.
I actually did that when I first created the MR. The only variable I had left was GF_SECURITY_ADMIN_PASSWORD because it already uses another field in the values.yaml file, but one of the tests failed. I'll push that commit again.
There was a problem hiding this comment.
org.scalatest.exceptions.TestFailedException: "2020-06-26T19:27:03.247708024Z stdout: params.param1: test1 2020-06-26T19:27:03.247795526Z stdout: params.param2: test2" did not include substring "params.payload: this is a test"
|
This should've been closed a while ago. |
Context
I am experimenting with Openwhisk and Openstack and currently using kubectl proxy to access the dashboard. However, for that to work, I have two options:
Change de variable on the fly:
kubectl -n openwhisk set env deployment/owdev-grafana GF_SERVER_ROOT_URL=http://localhost:8001/api/v1/namespaces/openwhisk/services/http:owdev-grafana:http/proxy/Replace the value in the manifest before installing the chart.
What would you expect?
To be able not only to set GF_SERVER_ROOT_URL but any other environment variable in the configuration file.
helm install owdev openwhisk/helm/openwhisk -n openwhisk --create-namespace -f mycluster.yaml